Conversation
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
christopherferreira9
left a comment
There was a problem hiding this comment.
nice nice nice!
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
✅ E2E Fixture Validation — Schema is up to date |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27434 +/- ##
==========================================
- Coverage 81.97% 81.97% -0.01%
==========================================
Files 4699 4732 +33
Lines 122881 123106 +225
Branches 27126 27187 +61
==========================================
+ Hits 100737 100920 +183
- Misses 15167 15203 +36
- Partials 6977 6983 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Description
Refactors multiple e2e page objects and flows to use the new framework-agnostic element/gesture layer (EncapsulatedElementType, UnifiedGestures, encapsulatedAction) so the same objects work under both Detox and Appium/Playwright.
Adds/adjusts selector plumbing to support this migration, including new localized selector text in NetworkEducationModal/WalletActionsBottomSheet test IDs, swipe option passthrough (speed, percentage) in UnifiedGestureOptions, and new swap/bridge performance-test helpers in QuoteView (token testId derivation, quote-visible assertion text, and network→chainId mapping).
Changelog
CHANGELOG entry:
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1563
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Refactors a wide set of e2e page objects and selectors to a new cross-framework abstraction, which can cause broad test failures if any locator mapping is wrong. App runtime behavior is largely unchanged aside from adding a few
testIDs used by automation.Overview
Updates e2e automation to use the framework-agnostic
EncapsulatedElementType/UnifiedGestures/encapsulatedActionAPIs across login, wallet, perps, networks, and swap/bridge page objects, including replacing direct Detox elements with dual Detox+Appium/Playwright locators.Extends selector plumbing to support the migration: adds new localized selector text constants, passes through swipe options (
speed,percentage) in unified gesture options, and adds swap/bridge helpers (fee-disclaimertestID, token testId derivation, network→chainId mapping, and quote-visibility assertions) to stabilize performance and deeplink tests.Written by Cursor Bugbot for commit e474ab6. This will update automatically on new commits. Configure here.