Skip to content

feat: modify OTA workflow#27386

Merged
weitingsun merged 1 commit into
mainfrom
wsun/modify-ota-workflow
Mar 13, 2026
Merged

feat: modify OTA workflow#27386
weitingsun merged 1 commit into
mainfrom
wsun/modify-ota-workflow

Conversation

@weitingsun

@weitingsun weitingsun commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Description

In the current workflow, the OTA PR needs to point to a base that is the same as the branch that we are applying the OTA to. However, this does not work because when we have a release branch, since the base is always stable so we will need to change the base branch whenever we run OTA update.

In this PR:

  • Get rid of hash commit input. We don't really need it because we will remove the approval if a new commit is pushed and we will always use the latest commit
  • We get the latest commit hash in the OTA PR and output it in the workflow
  • Remove the restriction on the OTA base branch. In the OTA PR, it shouldn't matter which base branch it's pointing to. We will compare the fingerprint to the actual release tag that the OTA is applying (which is one of the inputs when triggering the workflow)

workflow run: https://github.com/MetaMask/metamask-mobile/actions/runs/23026234415

Changelog

CHANGELOG entry: Removed OTA workflow commit hash input

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it changes the OTA release workflow’s source-of-truth for what gets built/published and removes prior base-branch/commit validation, which could result in publishing an unintended revision if PR context is wrong.

Overview
Updates the OTA push-eas-update workflow to publish from a PR’s current HEAD commit rather than a user-supplied commit SHA.

Reworks .github/scripts/validate-pr-commit.sh to resolve and output commit_sha for a given PR_NUMBER (no longer validates COMMIT_HASH or BASE_BRANCH), and wires this new output through checkout, dependency setup, fingerprint comparison, and the final push step; the manual commit_hash input and the old “validate PR contains commit” job are removed.

Written by Cursor Bugbot for commit 2d9dcd1. This will update automatically on new commits. Configure here.

@weitingsun weitingsun requested review from a team as code owners March 11, 2026 21:33
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to CI infrastructure files: .github/workflows/push-eas-update.yml and .github/scripts/validate-pr-commit.sh. There are no modifications to application source code, controllers, UI components, navigation, state management, or test infrastructure related to Detox E2E flows.

  • push-eas-update.yml affects the EAS update workflow (deployment pipeline), not runtime app behavior.
  • validate-pr-commit.sh is a PR commit validation script and does not impact app logic or user flows.

Since no wallet features, controllers, confirmations, network logic, account management, trading flows, snaps, or performance-sensitive areas were modified, running E2E feature test suites would not provide additional safety value for this PR.

There is also no indication that Detox configuration, test runners, or E2E workflow execution logic was modified.

Therefore, no E2E tags are required for functional validation of this change set.

Performance Test Selection:
No application runtime code, UI rendering logic, controller state management, asset loading, or startup logic was modified. The changes are limited to CI workflow and validation scripts, which have no impact on app performance characteristics. Therefore, performance tests are not required.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 12, 2026
@weitingsun weitingsun added this pull request to the merge queue Mar 13, 2026
Merged via the queue into main with commit 69f4c71 Mar 13, 2026
151 of 166 checks passed
@weitingsun weitingsun deleted the wsun/modify-ota-workflow branch March 13, 2026 00:22
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Mar 13, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 13, 2026
@metamaskbot metamaskbot added the release-7.71.0 Issue or pull request that will be included in release 7.71.0 label Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.71.0 Issue or pull request that will be included in release 7.71.0 size-M team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants