feat: modify OTA workflow#27386
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
Since no wallet features, controllers, confirmations, network logic, account management, trading flows, snaps, or performance-sensitive areas were modified, running E2E feature test suites would not provide additional safety value for this PR. There is also no indication that Detox configuration, test runners, or E2E workflow execution logic was modified. Therefore, no E2E tags are required for functional validation of this change set. Performance Test Selection: |
|



Description
In the current workflow, the OTA PR needs to point to a base that is the same as the branch that we are applying the OTA to. However, this does not work because when we have a release branch, since the base is always
stableso we will need to change the base branch whenever we run OTA update.In this PR:
workflow run: https://github.com/MetaMask/metamask-mobile/actions/runs/23026234415
Changelog
CHANGELOG entry: Removed OTA workflow commit hash input
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it changes the OTA release workflow’s source-of-truth for what gets built/published and removes prior base-branch/commit validation, which could result in publishing an unintended revision if PR context is wrong.
Overview
Updates the OTA
push-eas-updateworkflow to publish from a PR’s current HEAD commit rather than a user-supplied commit SHA.Reworks
.github/scripts/validate-pr-commit.shto resolve and outputcommit_shafor a givenPR_NUMBER(no longer validatesCOMMIT_HASHorBASE_BRANCH), and wires this new output through checkout, dependency setup, fingerprint comparison, and the final push step; the manualcommit_hashinput and the old “validate PR contains commit” job are removed.Written by Cursor Bugbot for commit 2d9dcd1. This will update automatically on new commits. Configure here.