Skip to content

feat: migrate Skeleton (swaps scope)#27363

Merged
kirillzyusko merged 1 commit into
mainfrom
feat/skeleton-migration-swaps-scope
Mar 12, 2026
Merged

feat: migrate Skeleton (swaps scope)#27363
kirillzyusko merged 1 commit into
mainfrom
feat/skeleton-migration-swaps-scope

Conversation

@kirillzyusko

@kirillzyusko kirillzyusko commented Mar 11, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Removed unused mocks.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-274

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test-only change that removes redundant Jest mocks; low risk aside from potentially reintroducing minor animation/timing differences in affected tests.

Overview
Removes the custom Jest mock for the Skeleton component from BridgeView.test.tsx and SwapsConfirmButton.test.tsx, relying on the real implementation during tests.

This cleans up unused test scaffolding in the Bridge/Swaps test suite without changing production behavior.

Written by Cursor Bugbot for commit e94e5df. This will update automatically on new commits. Configure here.

@kirillzyusko kirillzyusko self-assigned this Mar 11, 2026
@kirillzyusko kirillzyusko added the team-swaps-and-bridge Swaps and Bridge team label Mar 11, 2026
@github-actions

github-actions Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed files are unit test files for Bridge components (BridgeView.test.tsx and SwapsConfirmButton.test.tsx). There are no changes to application source code, controllers, Engine, navigation, UI components, or shared infrastructure. Since production code is untouched, there is no impact on user flows covered by Detox E2E tests. Therefore, no E2E tags need to be executed for validation.

Performance Test Selection:
No application logic, rendering logic, controllers, or performance-sensitive code was modified. Only unit test files were updated, so there is no potential impact on runtime performance.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Mar 11, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kirillzyusko kirillzyusko marked this pull request as ready for review March 12, 2026 11:59
@kirillzyusko kirillzyusko requested a review from a team as a code owner March 12, 2026 11:59
@kirillzyusko kirillzyusko added this pull request to the merge queue Mar 12, 2026
Merged via the queue into main with commit a29accb Mar 12, 2026
109 of 121 checks passed
@kirillzyusko kirillzyusko deleted the feat/skeleton-migration-swaps-scope branch March 12, 2026 20:12
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 12, 2026
@metamaskbot metamaskbot added the release-7.71.0 Issue or pull request that will be included in release 7.71.0 label Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ghgoodreau ghgoodreau ghgoodreau approved these changes

Assignees

@kirillzyusko kirillzyusko

Labels

release-7.71.0 Issue or pull request that will be included in release 7.71.0 size-XS team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kirillzyusko @ghgoodreau @metamaskbot