refactor: migrate renderBottomContent into independent component#27334
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
Any regression here could break the bridge execution path or prevent users from confirming transactions. Bridge is part of the Trade flows (SmokeTrade), and per tag rules, when selecting SmokeTrade for swap/bridge flows, SmokeConfirmations must also be selected because confirmations are part of the transaction flow. No controller logic or core Engine changes were introduced—this is a component extraction with equivalent logic—so broad wallet, identity, network, or multi-chain test suites are not required. Therefore:
No additional tags (e.g., SmokeWalletPlatform, SmokeNetworkExpansion, SmokeMultiChainAPI) are required because this change does not affect Trending, session permissions, or provider architecture. Performance Test Selection: |
|
✅ E2E Fixture Validation — Schema is up to date |
|



Description
migrate renderBottomContent into independent component
Changelog
CHANGELOG entry: N/A
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-4101
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk refactor that moves existing footer rendering logic into a new component and adds targeted tests; main risk is minor UI regression in when the confirm button/banners/disclaimer render.
Overview
Extracts
BridgeView’s inlinerenderBottomContentinto a newBridgeViewFootercomponent and wires it intoBridgeView, removing the duplicated footer logic and related imports.Adds a dedicated
BridgeViewFooter.test.tsxcovering render gating (loading/no quote/missing amount), hardware-wallet Solana banner, Blockaid alert banner, fee/no-fee disclaimer, and approval disclaimer/tooltip, while deleting the corresponding footer-specific tests fromBridgeView.test.tsx.Written by Cursor Bugbot for commit 8721336. This will update automatically on new commits. Configure here.