Skip to content

chore(runway): cherry-pick fix: update token selector font sizing#27332

Merged
chloeYue merged 1 commit into
release/7.69.0from
cherry-pick-7-69-0-6f10e3c
Mar 11, 2026
Merged

chore(runway): cherry-pick fix: update token selector font sizing#27332
chloeYue merged 1 commit into
release/7.69.0from
cherry-pick-7-69-0-6f10e3c

Conversation

@runway-github

@runway-github runway-github Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes the font sizing that was broken due to a design team
update.

Changelog

CHANGELOG entry: Fix bug where token selector fonts were too big

Related issues

Fixes: #27328

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Low risk visual-only changes to
BridgeTokenSelector/TokenSelectorItem typography and icon sizing
with no logic, data, or flow changes.

Overview
Updates the Bridge token selector UI to align with new sizing
guidelines by reducing the info ButtonIcon from Md to Sm and
dialing down token list text variants (e.g., balances and names from
BodyMD to BodySM, and symbol/balance weights from BodyMDMedium to
BodyMD).

Written by Cursor
Bugbot
for commit
684ccd6. This will update automatically
on new commits. Configure
here.

[6f10e3c](https://github.com/MetaMask/metamask-mobile/commit/6f10e3c101caba0fff7a5015bcca1e049b80374e)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

This PR fixes the font sizing that was broken due to a design team
update.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Fix bug where token selector fonts were too big

Fixes: #27328

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk visual-only changes to
`BridgeTokenSelector`/`TokenSelectorItem` typography and icon sizing
with no logic, data, or flow changes.
>
> **Overview**
> Updates the Bridge token selector UI to align with new sizing
guidelines by reducing the info `ButtonIcon` from `Md` to `Sm` and
dialing down token list text variants (e.g., balances and names from
`BodyMD` to `BodySM`, and symbol/balance weights from `BodyMDMedium` to
`BodyMD`).
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
684ccd6. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner March 11, 2026 10:16
@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Mar 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.69.0)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 0
Value mismatches 6 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@chloeYue chloeYue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfullam bfullam added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Mar 11, 2026
@chloeYue chloeYue merged commit cc22b1b into release/7.69.0 Mar 11, 2026
372 of 383 checks passed
@chloeYue chloeYue deleted the cherry-pick-7-69-0-6f10e3c branch March 11, 2026 13:02
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 11, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 12, 2026
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.69.0 on PR, as PR was cherry-picked in branch 7.69.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-XS skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants