refactor: Updated perps market details header#27316
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…to refactor/header-perps-market-details
…to refactor/header-perps-market-details
|
Skipping sonar since its failing on "duplication" check, which is from similar checks for string type |
…to refactor/header-perps-market-details
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
…to refactor/header-perps-market-details
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: According to tag rules:
No controller, Engine, network, identity, or trade/swap logic changes were made, so other tags are not required. Performance Test Selection: |
|
✅ E2E Fixture Validation — Schema is up to date |
|


Description
Refactors the Perps Market Details screen to use the shared
HeaderStandardAnimatedcomponent instead of the customPerpsMarketHeaderand navbar options, aligning with patterns used elsewhere (e.g. Perps home, Token Details).getPerpsMarketDetailsNavbar(navigation.setOptions) and a customPerpsMarketHeadercomponent; this was inconsistent with other screens that use component-library header primitives and scroll-linked header animation.PerpsMarketHeaderwithHeaderStandardAnimated. Title is${getPerpsDisplaySymbol(market.symbol)}-USD; subtitle isLivePriceHeader(symbol, current price, throttle). Back button, fullscreen (expand) and watchlist (star) actions are passed asendButtonIconProps. Removed the navbaruseEffect. Scroll content is now anAnimated.ScrollViewwith scroll passed to the header; aTitleSubpageblock at the top (token logo, title, leverage badge, andLivePriceHeaderas bottom accessory) drives the title section height viaonLayoutanduseHeaderStandardAnimated.LivePriceHeadertext variants were updated toBodySMand price color toAlternativefor the compact header context.Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/issues?jql=issueKey%20in%20(DSYS-555%2CDSYS-556%2CDSYS-557%2CDSYS-558)&selectedIssue=DSYS-558
Manual testing steps
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-03-10.at.15.13.51.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Refactors the Perps Market Details header/navigation and scroll handling, which could introduce UI regressions (collapsed header behavior, button actions, layout) on a high-traffic trading screen. No changes to trading/business logic or data handling.
Overview
Refactors the Perps Market Details screen to use the shared
HeaderStandardAnimatedpattern instead of the bespokePerpsMarketHeaderandnavigation.setOptionsnavbar configuration.The header is now driven by
useHeaderStandardAnimatedand anAnimated.ScrollView, with a new top-of-pageTitleSubpagesection (token logo, title, leverage badge, and live price) providing the measured height for the collapse/expand animation; fullscreen and watchlist actions are wired through header icon props.Updates
HeaderStandardAnimatedto accept non-stringtitle/subtitlenodes, adjustsLivePriceHeadertypography for the compact header, removes the unusedgetPerpsMarketDetailsNavbar, and extends Perps test IDs/tests to account for duplicated title rendering (header + title section) and new price/change selectors.Written by Cursor Bugbot for commit 0f37d84. This will update automatically on new commits. Configure here.