Skip to content

chore(runway): cherry-pick fix: try fixing X deeplinks by adding [GE-139] cp-7.69.0#27309

Merged
chloeYue merged 1 commit into
release/7.69.0from
runway-cherry-pick-7.69.0-1773185599
Mar 11, 2026
Merged

chore(runway): cherry-pick fix: try fixing X deeplinks by adding [GE-139] cp-7.69.0#27309
chloeYue merged 1 commit into
release/7.69.0from
runway-cherry-pick-7.69.0-1773185599

Conversation

@runway-github

@runway-github runway-github Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Description

Fix branch deeplinks not working with the X (Twitter) app by adding a
$deeplink_path param in branch.io and consuming it in MetaMask Mobile.

Context

What we found

  1. No resolved URI from the SDK
  • The Branch iOS SDK (and react-native-branch) give us:
  • The raw URL that opened the app (e.g.
    https://metamask-alternate.app.link/1WkF6GmE40b?...), and
  • The params from the session (e.g. from getLatestReferringParams() /
    subscribe callback).
  • The SDK does not build a custom deeplink URI (e.g. metamask://swap)
    from link data; it only returns the params. So we have to do routing
    ourselves.
  1. Implemented fix:
  • Added a $deeplink_path in Branch deeplinks (this must be added to
    every existing and future deeplinks that we want to post on X)
  • Read it from the params and build our deeplink ourselves (e.g.
    metamask://${params.$deeplink_path}) and then route inside the app.

Changelog

CHANGELOG entry: Fixed a bug that was causing deeplinks opened from X
app to fail

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/GE-139
Fixes: #27140

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Touches deeplink routing/host allowlists and Branch handling on app
start, which can affect navigation from external links, but the change
is narrowly scoped and covered by new unit tests.

Overview
Fixes Branch short-link universal links (notably from X on iOS) by
introducing rewriteBranchUri, which converts
metamask-alternate.app.link/<id> URLs into
https://link.metamask.io/<$deeplink_path> while preserving query
params.

DeeplinkManager.start() now applies this rewrite for both cold-start
Branch params (~referring_link) and branch.subscribe events,
replacing the prior getLatestReferringParams fallback logic.

Adds MM_UNIVERSAL_LINK_HOST_ALTERNATE
(metamask-alternate.app.link) and includes it in universal-link host
validation (handleUniversalLink) and MetaMask-host detection
(util/deeplinks), with new tests covering rewrite and routing
behavior.

Written by Cursor
Bugbot
for commit
de4e3dc. This will update automatically
on new commits. Configure
here.

[0696104](https://github.com/MetaMask/metamask-mobile/commit/06961042ca4be1925a9f55a5318902575b999d5b)

…139] cp-7.69.0 (#27139)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Fix branch deeplinks not working with the X (Twitter) app by adding a
`$deeplink_path` param in branch.io and consuming it in MetaMask Mobile.

### Context

- Platform: happens only on iOS. Android behaves differently (no
Deepview in our flow).
- User taps a t.co link in X (Twitter) → redirects to
https://metamask.app.link/1WkF6GmE40b (which is a link generated by
X/Branch.io on Tweet posting) → Branch Deepview is shown → user taps
“Get the app” → opens MetaMask via Universal Link:
https://metamask-alternate.app.link/1WkF6GmE40b?__branch_flow_type=viewapp&__branch_flow_id=...&__branch_mobile_deepview_type=1.
- Issue: The app opens correctly, but in-app we show a “page not found”
(404). So the OS and Branch open the app, but we don’t know which in-app
route corresponds to link ID 1WkF6GmE40b.

### What we found

1. No resolved URI from the SDK
- The Branch iOS SDK (and react-native-branch) give us:
- The raw URL that opened the app (e.g.
https://metamask-alternate.app.link/1WkF6GmE40b?...), and
- The params from the session (e.g. from getLatestReferringParams() /
subscribe callback).
- The SDK does not build a custom deeplink URI (e.g. metamask://swap)
from link data; it only returns the params. So we have to do routing
ourselves.

2. Implemented fix:
- Added a $deeplink_path in Branch deeplinks (this must be added to
every existing and future deeplinks that we want to post on X)
- Read it from the params and build our deeplink ourselves (e.g.
metamask://${params.$deeplink_path}) and then route inside the app.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Fixed a bug that was causing deeplinks opened from X
app to fail

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/GE-139
Fixes: #27140

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Touches deeplink routing/host allowlists and Branch handling on app
start, which can affect navigation from external links, but the change
is narrowly scoped and covered by new unit tests.
> 
> **Overview**
> Fixes Branch short-link universal links (notably from X on iOS) by
introducing `rewriteBranchUri`, which converts
`metamask-alternate.app.link/<id>` URLs into
`https://link.metamask.io/<$deeplink_path>` while preserving query
params.
> 
> `DeeplinkManager.start()` now applies this rewrite for both cold-start
Branch params (`~referring_link`) and `branch.subscribe` events,
replacing the prior `getLatestReferringParams` fallback logic.
> 
> Adds `MM_UNIVERSAL_LINK_HOST_ALTERNATE`
(`metamask-alternate.app.link`) and includes it in universal-link host
validation (`handleUniversalLink`) and MetaMask-host detection
(`util/deeplinks`), with new tests covering rewrite and routing
behavior.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
de4e3dc. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner March 10, 2026 23:33
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Mar 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.69.0)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 0
Value mismatches 6 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@chloeYue chloeYue merged commit c280f57 into release/7.69.0 Mar 11, 2026
279 of 284 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.69.0-1773185599 branch March 11, 2026 08:55
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 11, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 11, 2026
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.69.0 on PR, as PR was cherry-picked in branch 7.69.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants