feat: MUSD-454 add quick convert event tracking cp-7.70.0 by Matt561 · Pull Request #27305 · MetaMask/metamask-mobile

Matt561 · 2026-03-10T23:10:59Z

Description

Changes:

Adds Segment event tracking for the mUSD Quick Convert flow
Enriches generic Transaction* events for musdConversion transactions
- Adds confirmation_source to differentiate between the "Max" convert bottom sheet and custom amount confirmations
- Adds is_max which is true when "Max" conversion flow is used or when custom amount is used and user clicks "Max" button in percentage button row
- Adds mUSD quote tracking data

Events

Event	Type	Location	Description
`mUSD Quick Convert Screen Viewed`	New standalone event	`MusdQuickConvertView` (on mount)	Fires when the quick convert token list screen is viewed
`mUSD Bonus Terms of Use Pressed`	New standalone event	`MusdQuickConvertView` (`quick_convert_home_screen`), `EarnMusdConversionEducationView` (`conversion_education_screen`), `useMusdConversionNavbar` (`custom_amount_navbar`), `PercentageRow` (`percentage_row`)	Fires when user presses the bonus terms of use link; `location` property differentiates the source
`mUSD Quick Convert Token Row Button Clicked`	New standalone event	`MusdQuickConvertView`	Fires on "Max" or "Edit" button tap; includes `button_action`, `redirects_to`, asset details
`confirmation_source`	New property on `Transaction*` events	`useMusdConversionConfirmationMetrics`	`'quick_convert_max_bottom_sheet_confirmation_screen'` or `'custom_amount_screen'` — only attached to `musdConversion` transactions
`is_max`	New property on `Transaction*` events	`useMusdConversionConfirmationMetrics`	Derived from `TransactionPayController.isMaxAmount` — only attached to `musdConversion` transactions
Quote tracking data	New properties on `Transaction*` events	`useMusdConversionConfirmationMetrics`	Standardized quote/pay data via `getMusdConversionQuoteTrackingData` — only attached to `musdConversion` transactions

Changelog

CHANGELOG entry: Added Segment event tracking for mUSD Quick Convert flow and enrich generic Transaction* events for mUSD conversion transactions

Related issues

Fixes: MUSD-454: Add segment events for Quick Convert flow

Manual testing steps

Feature: mUSD Quick Convert Segment event tracking

  Scenario: user views the quick convert screen
    Given user navigates to the mUSD Quick Convert screen

    When the screen mounts
    Then "mUSD Quick Convert Screen Viewed" event fires with location "quick_convert_home_screen"

  Scenario: user taps Max on a token row
    Given user is on the mUSD Quick Convert screen with convertible tokens

    When user taps "Max" on a token row
    Then "mUSD Quick Convert Token Row Button Clicked" event fires with button_action "max" and redirects_to "quick_convert_max_bottom_sheet_confirmation_screen"

  Scenario: user taps Edit on a token row
    Given user is on the mUSD Quick Convert screen with convertible tokens

    When user taps the edit icon on a token row
    Then "mUSD Quick Convert Token Row Button Clicked" event fires with button_action "custom" and redirects_to "custom_amount_screen"

  Scenario: user taps "Terms apply" link on the quick convert screen
    Given user is on a screen displaying the mUSD bonus "Terms apply" link

    When user taps "Terms apply"
    Then "mUSD Bonus Terms of Use Pressed" event fires with the location of the current screen

  Scenario: user confirms a max mUSD conversion
    Given user is on the max convert bottom sheet confirmation

    When user taps "Convert"
    Then "Transaction Approved" event includes confirmation_source "quick_convert_max_bottom_sheet_confirmation_screen", "is_max: true", and quote tracking data

  Scenario: user confirms a custom amount mUSD conversion
    Given user is on the custom amount conversion screen

    When user taps "Convert"
    Then "Transaction Approved" event includes confirmation_source "custom_amount_screen", "is_max: false"

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds new MetaMetrics events and confirmation-metric dispatches across mUSD conversion/confirmation screens; while behavior is mostly observational, it touches confirmations flow and transaction status tracking and could affect analytics payloads or introduce unintended side effects if hooks fire unexpectedly.

Overview
Adds MetaMetrics tracking for the mUSD Quick Convert flow, including MUSD_QUICK_CONVERT_SCREEN_VIEWED, MUSD_QUICK_CONVERT_TOKEN_ROW_BUTTON_CLICKED (Max/Edit), and MUSD_BONUS_TERMS_OF_USE_PRESSED with location/context properties.

Introduces a shared analytics utility (getMusdConversionQuoteTrackingData + deepSnakeCaseKeys) and refactors useMusdConversionStatus to use it when emitting MUSD_CONVERSION_STATUS_UPDATED, standardizing quote-derived properties.

Enriches confirmation metrics for musdConversion by adding a new useMusdConversionConfirmationMetrics hook (wired into MusdConversionInfoRoot) that dispatches confirmation_source, is_max, and select quote fields into confirmationMetrics. Tests are updated/added accordingly, and EVENT_LOCATIONS/MetaMetricsEvents are extended to support the new instrumentation.

^{Written by Cursor Bugbot for commit 6e2e686. This will update automatically on new commits. Configure here.}

… on Quick Convert screen

…fo-root to enrich mUSD conversion transaction events

…ement

github-actions · 2026-03-10T23:11:08Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…ransactionId missing

…EN_VIEWED event

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

…N_VIEWED event when quick convert feature is disabled

….test.ts

…order to keep typing of DeepSnakeCaseKeys accurate

…onvert-flow

…CK_CONVERT_TOKEN_ROW_BUTTON_CLICKED event

…onvert-flow

github-actions · 2026-03-12T18:05:56Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeConfirmations, SmokeTrade
Selected Performance tags: None (no tests recommended)
Risk Level: medium
AI Confidence: 75%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes focus on the Earn mUSD conversion feature, including new/updated views, hooks, analytics utilities, and confirmation UI components (musd-conversion-info-root, percentage-row, confirmation metrics hooks). Additionally, app/core/Analytics/MetaMetrics.events.ts (a critical file) was modified, which can affect analytics event definitions used across the app.

Key impact areas:

Confirmation UI Layer (High relevance to SmokeConfirmations):
- Changes under app/components/Views/confirmations/components/info/ and rows/ directly modify confirmation screen subcomponents.
- New metrics hooks for mUSD conversion confirmations indicate integration with the confirmation flow.
- Even if scoped to mUSD, these components live in the shared confirmation system, which is used by send, approve, swap, and contract interactions.
  → SmokeConfirmations is required to validate no regressions in transaction/signature confirmation flows.
Earn feature entry via Trade wallet actions (Relevant to SmokeTrade):
- Earn is accessed from the TradeWalletActions bottom sheet (same entry surface as Swap, Bridge, Perps, Predictions).
- UI and analytics changes in Earn views could affect navigation or shared wallet actions infrastructure.
- While not directly modifying swap logic, SmokeTrade ensures the Trade entry points and related flows remain stable.
  → SmokeTrade selected as a safety net for Trade menu integration.
Analytics (MetaMetrics.events.ts):
- Changes to event definitions can affect tracking across flows, but are unlikely to break functional behavior.
- No direct controller, Engine, network, multi-chain, or account architecture changes detected.

No changes were found in Engine, Controllers, network management, account management, multi-SRP, Snaps, Card, Perps, Predictions, Ramps, or MultiChain API layers.

Therefore, targeted validation of confirmation flows and Trade entry points is sufficient without running the entire E2E suite.

Performance Test Selection:
Changes are limited to UI components, hooks, and analytics related to mUSD conversion and confirmation display. There are no modifications to Engine initialization, account lists, token/balance loading, onboarding, swaps performance paths, predictions/perps market loading, or app launch logic. No large list rendering or performance-critical code paths were altered. Therefore, performance tests are not required.

View GitHub Actions results

github-actions · 2026-03-12T18:25:26Z

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

sonarqubecloud · 2026-03-12T18:30:56Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
98.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Matt561 added 5 commits March 9, 2026 16:47

feat: added event tracking for "terms apply" links in conversion flows

17fef0c

feat: added MUSD_QUICK_CONVERT_SCREEN_VIEWED event

2a7abbe

feat: added event tracking for "Max" and "Edit" (pencil icon) buttons…

f9f91c2

… on Quick Convert screen

feat: added useMusdConversionConfirmationMetric to musd-conversion-in…

155955f

…fo-root to enrich mUSD conversion transaction events

feat: removed chainIdsMatch util in favour of existing drop-in replac…

296a991

…ement

Matt561 requested review from a team as code owners March 10, 2026 23:11

Matt561 added No QA Needed Apply this label when your PR does not need any QA effort. team-earn labels Mar 10, 2026

github-actions Bot added the size-XL label Mar 10, 2026

cursor Bot reviewed Mar 10, 2026

View reviewed changes

Comment thread app/components/Views/confirmations/hooks/metrics/useMusdConversionConfirmationMetrics.ts

feat: prevent dispatch in useMusdConversionConfirmationMetrics when t…

aac29a3

…ransactionId missing

cursor Bot reviewed Mar 10, 2026

View reviewed changes

Comment thread app/components/UI/Earn/utils/analytics.types.ts

matthewwalsh0 previously approved these changes Mar 11, 2026

View reviewed changes

feat: fix failing custom-amount-info-test.tsx suite

02729b8

Matt561 dismissed matthewwalsh0’s stale review via 02729b8 March 11, 2026 14:31

cursor Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread app/components/UI/Earn/Views/MusdQuickConvertView/index.tsx Outdated

feat: removed redundant location property for MUSD_QUICK_CONVERT_SCRE…

261ebcd

…EN_VIEWED event

cursor Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread app/components/Views/confirmations/hooks/metrics/useMusdConversionConfirmationMetrics.test.ts Outdated

Matt561 added 2 commits March 11, 2026 11:38

feat: added early return to MusdQuickConvert MUSD_QUICK_CONVERT_SCREE…

ddc2087

…N_VIEWED event when quick convert feature is disabled

feat: updated test case names in useMusdConversionConfirmationMetrics…

aa3a497

….test.ts

Matt561 requested a review from matthewwalsh0 March 11, 2026 16:01

nickewansmith previously approved these changes Mar 11, 2026

View reviewed changes

nickewansmith self-requested a review March 11, 2026 16:56

Matt561 enabled auto-merge March 11, 2026 18:19

Matt561 disabled auto-merge March 11, 2026 18:19

feat: update deepSnakeCaseKeys to not use lodash's snakecase util in …

d810b0a

…order to keep typing of DeepSnakeCaseKeys accurate

Matt561 dismissed nickewansmith’s stale review via d810b0a March 11, 2026 19:05

Merge branch 'main' into feat/musd-454-add-segment-events-for-quick-c…

f2c9478

…onvert-flow

nickewansmith previously approved these changes Mar 11, 2026

View reviewed changes

feat: remove balance_decimal and balance_hex properties from MUSD_QUI…

9f36e60

…CK_CONVERT_TOKEN_ROW_BUTTON_CLICKED event

Matt561 dismissed nickewansmith’s stale review via 9f36e60 March 11, 2026 23:37

Matt561 requested a review from nickewansmith March 11, 2026 23:42

matthewwalsh0 previously approved these changes Mar 12, 2026

View reviewed changes

feat: removed properties that overlapped with existing mm_pay properties

dba4514

Matt561 dismissed matthewwalsh0’s stale review via dba4514 March 12, 2026 15:01

Merge branch 'main' into feat/musd-454-add-segment-events-for-quick-c…

2aa7062

…onvert-flow

Matt561 requested a review from matthewwalsh0 March 12, 2026 15:02

nickewansmith approved these changes Mar 12, 2026

View reviewed changes

matthewwalsh0 approved these changes Mar 12, 2026

View reviewed changes

Matt561 enabled auto-merge March 12, 2026 17:39

nickewansmith approved these changes Mar 12, 2026

View reviewed changes

Merge branch 'main' into feat/musd-454-add-segment-events-for-quick-c…

6e2e686

…onvert-flow

Matt561 added this pull request to the merge queue Mar 12, 2026

Merged via the queue into main with commit 15edc39 Mar 12, 2026
117 of 122 checks passed

Matt561 deleted the feat/musd-454-add-segment-events-for-quick-convert-flow branch March 12, 2026 19:28

github-actions Bot locked and limited conversation to collaborators Mar 12, 2026

metamaskbot added the release-7.71.0 Issue or pull request that will be included in release 7.71.0 label Mar 12, 2026

chloeYue changed the title ~~feat: MUSD-454 add quick convert event tracking~~ feat: MUSD-454 add quick convert event tracking cp-7.70.0 Mar 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: MUSD-454 add quick convert event tracking cp-7.70.0#27305

feat: MUSD-454 add quick convert event tracking cp-7.70.0#27305
Matt561 merged 16 commits into
mainfrom
feat/musd-454-add-segment-events-for-quick-convert-flow

Matt561 commented Mar 10, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Mar 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 12, 2026

Uh oh!

github-actions Bot commented Mar 12, 2026

Uh oh!

sonarqubecloud Bot commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Matt561 commented Mar 10, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes:

Events

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 12, 2026

🔍 Smart E2E Test Selection

Uh oh!

github-actions Bot commented Mar 12, 2026

Uh oh!

sonarqubecloud Bot commented Mar 12, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Matt561 commented Mar 10, 2026 •

edited by cursor Bot

Loading