fix(ramp): Navigate to token list on close unavailable modal#27297
Merged
amitabh94 merged 7 commits intoMar 10, 2026
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
amitabh94
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the "Token not available with provider" modal so that pressing the close (
X) button navigates the user back to the token selection screen instead of leaving them in a stuck state.Previously, closing the modal did nothing — the bottom sheet dismissed but no navigation occurred, leaving the user on a blank/unresponsive input screen. Now the close button behaves the same as the "Change token" button, sending the user back to the token list.
Changelog
CHANGELOG entry: Fixed a bug where closing the "Token not available" modal left the user in a stuck state instead of navigating back to the token selection screen.
Related issues
Refs: TRAM-3329
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2026-03-10.122119.mp4
After
Screen.Recording.2026-03-10.161542.mp4
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Small, isolated navigation change on modal dismissal with added test coverage; minimal impact outside the ramp modal flow.
Overview
Fixes
ProviderSelectionModalso dismissing the bottom sheet (e.g., tapping outside/close) triggers navigation back toRoutes.RAMP.TOKEN_SELECTIONwhen the modal is shown inskipQuotesmode (i.e., no pending post-action).Updates tests to mock
navigate, capture theBottomSheetonClosecallback, and assert navigation occurs only forskipQuotes: trueand not for the normal quotes flow.Written by Cursor Bugbot for commit 69669e2. This will update automatically on new commits. Configure here.