chore(runway): cherry-pick fix(perps): route deposit flow to redesigned confirmations with perps header#27231
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
joaoloureirop
approved these changes
Mar 9, 2026
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.69.0) All E2E tests pre-selected. |
Contributor
The committed fixture schema is out of date. To update, comment: |
|
Collaborator
|
No release label on PR. Adding release label release-7.69.0 on PR, as PR was cherry-picked in branch 7.69.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The perps deposit flow was using
navigateToConfirmation({ stack: Routes.PERPS.ROOT }), which did not correctly route users to theredesigned confirmations screen after initiating a deposit. Users could
end up on the wrong confirmation stack or without the perps-specific
header.
This change updates the flow so that when the user taps the Perps
balance token to deposit:
handleReject()from
useApprovalRequest.depositWithConfirmation()runs to start the deposit flow.REDESIGNED_CONFIRMATIONSwithshowPerpsHeader: trueinstead of the previous PERPS.ROOT stack.Dependencies on
useConfirmNavigationare removed in favor ofuseNavigationanduseApprovalRequestso the deposit action andpost-deposit navigation are explicit and aligned with the redesigned
confirmations screen.
Changelog
CHANGELOG entry: Fixed perps deposit flow so it routes to the redesigned
confirmations screen with the perps header after a successful deposit.
Related issues
Fixes:
https://consensys.slack.com/archives/C092T3GPHQD/p1772719051867319
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Changes the perps deposit tap-handler to dismiss the current approval
and navigate to a different confirmation route, so regressions could
strand users on the wrong screen or break the deposit flow sequencing.
Overview
Fixes the Perps “Add funds” action from the synthetic “Perps
balance” token so it no longer uses
useConfirmNavigation/Routes.PERPS.ROOT.The handler now calls
useApprovalRequest().onReject()to dismiss thecurrent approval, runs
depositWithConfirmation(), and then navigatesvia React Navigation to
Routes.FULL_SCREEN_CONFIRMATIONS.REDESIGNED_CONFIRMATIONSwithshowPerpsHeader: true. Tests were updated to mock the new hooks(
useNavigation,useApprovalRequest) and assert the new callorder/route using
waitFor.Written by Cursor
Bugbot for commit
48571b0. This will update automatically
on new commits. Configure
here.