Skip to content

feat(predict): show FAK partial fill note in price details breakdown cp-7.69.0#27218

Merged
matallui merged 7 commits into
mainfrom
predict/fak-ui
Mar 9, 2026
Merged

feat(predict): show FAK partial fill note in price details breakdown cp-7.69.0#27218
matallui merged 7 commits into
mainfrom
predict/fak-ui

Conversation

@matallui

@matallui matallui commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Description

When FAK (Fill-And-Kill) orders are enabled, the PredictFeeBreakdownSheet now displays a footnote below the Total row explaining that prices assume a fully filled order and actual amounts may vary if the order is only partially filled.

Additionally, the component was refactored to use @metamask/design-system-react-native primitives (Text, TextColor, TextVariant, FontWeight) instead of the local component-library Text, aligning with the project's UI development guidelines.

Changes:

  • Created selectPredictFakOrdersEnabledFlag Redux selector for the predictFakOrders version-gated remote feature flag
  • Added fakOrdersEnabled prop to PredictFeeBreakdownSheet — conditionally renders a partial fill note
  • Wired PredictBuyPreview to read the selector and pass it to the sheet
  • Migrated Text, TextColor, TextVariant imports from component-library to @metamask/design-system-react-native
  • Replaced TextVariant.BodyMDBold with TextVariant.BodyMd + fontWeight={FontWeight.Bold}

Changelog

CHANGELOG entry: Added a note in prediction price details explaining that prices assume a fully filled order when FAK orders are enabled

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/PRED-722

Manual testing steps

Feature: FAK partial fill note in price details

  Scenario: user sees partial fill note when FAK orders flag is enabled
    Given the predictFakOrders remote feature flag is enabled
    And the user is on the buy prediction preview screen

    When user taps on the price details row to open the fee breakdown sheet
    Then a note is displayed below the Total row reading "Prices shown assume your order is fully filled. Actual amounts may vary if the order is only partially filled."

  Scenario: user does not see partial fill note when FAK flag is disabled
    Given the predictFakOrders remote feature flag is disabled
    And the user is on the buy prediction preview screen

    When user taps on the price details row to open the fee breakdown sheet
    Then no partial fill note is displayed below the Total row

Screenshots/Recordings

Before

Screenshot 2026-03-09 at 1 19 11 PM

After

Screenshot 2026-03-09 at 1 20 36 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI/feature-flag change that adds conditional copy and a new selector; main risk is incorrect flag evaluation or unintended note display.

Overview
Predict price details now conditionally shows a FAK partial-fill disclaimer when the remote predictFakOrders version-gated flag is enabled.

This introduces selectPredictFakOrdersEnabledFlag, wires it into PredictBuyPreview to pass fakOrdersEnabled to PredictFeeBreakdownSheet, and updates the sheet to render the new footnote (plus a small refactor to @metamask/design-system-react-native Text primitives via a reusable FeeRow). Tests and en.json strings are updated accordingly.

Written by Cursor Bugbot for commit 9bf73d0. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-predict Predict team label Mar 9, 2026
@matallui matallui marked this pull request as ready for review March 9, 2026 19:18
@matallui matallui requested a review from a team as a code owner March 9, 2026 19:18
@github-actions github-actions Bot added the size-M label Mar 9, 2026
@matallui matallui changed the title feat(predict): show FAK partial fill note in price details breakdown feat(predict): show FAK partial fill note in price details breakdown cp-7.69.0 Mar 9, 2026
caieu
caieu previously approved these changes Mar 9, 2026

@caieu caieu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matallui matallui enabled auto-merge March 9, 2026 20:18

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread app/components/UI/Predict/selectors/featureFlags/index.ts
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: @PerformancePredict
  • Risk Level: medium
  • AI Confidence: 80%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are isolated to the Predict (Polymarket) feature area, including PredictFeeBreakdownSheet component, PredictBuyPreview view, feature flag selectors, related unit tests, and English locale strings. These directly impact the Predictions trading flow UI and potentially transaction preview/fee display logic.

Per tag rules:

  • SmokePredictions is required because the Predict UI and buy preview flow are directly modified.
  • SmokeWalletPlatform must also be selected since Predictions is embedded within the Trending tab and any changes to its views can affect the integrated wallet platform experience.
  • SmokeConfirmations must be selected because opening/closing prediction positions involves on-chain transactions, and changes to buy preview/fee breakdown could affect confirmation flows.

No core Engine, Controller, network, account, or trade (swap/bridge) logic was modified, so other tags are not required.

Performance Test Selection:
Changes affect PredictBuyPreview and fee breakdown UI, which are part of the prediction market flow. These could impact render time and responsiveness of the Predict market and buy flow screens. Running @PerformancePredict ensures market loading and buy flow performance remain within acceptable thresholds. No changes suggest impact to launch, login, swaps, perps, or global asset loading performance.

View GitHub Actions results

@caieu caieu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
9 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

sonarqubecloud Bot commented Mar 9, 2026

Copy link
Copy Markdown

@matallui matallui added this pull request to the merge queue Mar 9, 2026
Merged via the queue into main with commit 7e988fc Mar 9, 2026
100 checks passed
@matallui matallui deleted the predict/fak-ui branch March 9, 2026 21:25
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2026
@metamaskbot metamaskbot added the release-7.70.0 Issue or pull request that will be included in release 7.70.0 label Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.70.0 Issue or pull request that will be included in release 7.70.0 size-M team-predict Predict team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants