feat(predict): show FAK partial fill note in price details breakdown cp-7.69.0#27218
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…PredictFeeBreakdownSheet
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Per tag rules:
No core Engine, Controller, network, account, or trade (swap/bridge) logic was modified, so other tags are not required. Performance Test Selection: |
|
✅ E2E Fixture Validation — Schema is up to date |
|



Description
When FAK (Fill-And-Kill) orders are enabled, the PredictFeeBreakdownSheet now displays a footnote below the Total row explaining that prices assume a fully filled order and actual amounts may vary if the order is only partially filled.
Additionally, the component was refactored to use
@metamask/design-system-react-nativeprimitives (Text,TextColor,TextVariant,FontWeight) instead of the localcomponent-libraryText, aligning with the project's UI development guidelines.Changes:
selectPredictFakOrdersEnabledFlagRedux selector for thepredictFakOrdersversion-gated remote feature flagfakOrdersEnabledprop toPredictFeeBreakdownSheet— conditionally renders a partial fill notePredictBuyPreviewto read the selector and pass it to the sheetText,TextColor,TextVariantimports fromcomponent-libraryto@metamask/design-system-react-nativeTextVariant.BodyMDBoldwithTextVariant.BodyMd+fontWeight={FontWeight.Bold}Changelog
CHANGELOG entry: Added a note in prediction price details explaining that prices assume a fully filled order when FAK orders are enabled
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/PRED-722
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI/feature-flag change that adds conditional copy and a new selector; main risk is incorrect flag evaluation or unintended note display.
Overview
Predict price details now conditionally shows a FAK partial-fill disclaimer when the remote
predictFakOrdersversion-gated flag is enabled.This introduces
selectPredictFakOrdersEnabledFlag, wires it intoPredictBuyPreviewto passfakOrdersEnabledtoPredictFeeBreakdownSheet, and updates the sheet to render the new footnote (plus a small refactor to@metamask/design-system-react-nativeTextprimitives via a reusableFeeRow). Tests anden.jsonstrings are updated accordingly.Written by Cursor Bugbot for commit 9bf73d0. This will update automatically on new commits. Configure here.