Skip to content

chore(runway): cherry-pick fix: mixpanel event missing property cp-7.69.0#27191

Merged
joaoloureirop merged 1 commit into
release/7.69.0from
runway-cherry-pick-7.69.0-1773052927
Mar 9, 2026
Merged

chore(runway): cherry-pick fix: mixpanel event missing property cp-7.69.0#27191
joaoloureirop merged 1 commit into
release/7.69.0from
runway-cherry-pick-7.69.0-1773052927

Conversation

@runway-github

@runway-github runway-github Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Description

Bug fix

Fixed market_insights_displayed always reporting false in the
TOKEN_DETAILS_OPENED event by initializing isLoading to true in
useMarketInsights when a fetch will occur, preventing a race condition
where the tracking callback fired before loading started and
deduplication blocked the correct value

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TSA-243

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Low risk state-initialization change in a React hook; main risk is a
minor behavior shift where isLoading may start true when enabled and
an asset id is present.

Overview
Fixes a race where market insights tracking could run before loading
begins by initializing useMarketInsights’s isLoading state to true
whenever the hook is enabled and a caip19Id is provided, ensuring
first-render consumers don’t see a transient “not loading” state before
the initial fetch.

Written by Cursor
Bugbot
for commit
2033d2c. This will update automatically
on new commits. Configure
here.

[fd5adac](https://github.com/MetaMask/metamask-mobile/commit/fd5adacf096cadf89bebf0b9158816e1589a6db0)

…69.0 (#27187)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

**Bug fix**

Fixed market_insights_displayed always reporting false in the
`TOKEN_DETAILS_OPENED` event by initializing `isLoading` to true in
`useMarketInsights` when a fetch will occur, preventing a race condition
where the tracking callback fired before loading started and
deduplication blocked the correct value

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/TSA-243

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk state-initialization change in a React hook; main risk is a
minor behavior shift where `isLoading` may start `true` when enabled and
an asset id is present.
> 
> **Overview**
> Fixes a race where market insights tracking could run before loading
begins by initializing `useMarketInsights`’s `isLoading` state to `true`
whenever the hook is enabled and a `caip19Id` is provided, ensuring
first-render consumers don’t see a transient “not loading” state before
the initial fetch.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
2033d2c. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Mar 9, 2026
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.69.0)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Mar 9, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 0
Value mismatches 6 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@joaoloureirop joaoloureirop enabled auto-merge (squash) March 9, 2026 17:08
@joaoloureirop joaoloureirop merged commit e6e0b34 into release/7.69.0 Mar 9, 2026
106 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.69.0-1773052927 branch March 9, 2026 17:08
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 10, 2026
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.69.0 on PR, as PR was cherry-picked in branch 7.69.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-XS team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants