Skip to content

chore(runway): cherry-pick revert(predict): remove Polymarket balance/allowance refresh workaround cp-7.69.0#27166

Merged
joaoloureirop merged 1 commit into
release/7.69.0from
runway-cherry-pick-7.69.0-1772842910
Mar 9, 2026
Merged

chore(runway): cherry-pick revert(predict): remove Polymarket balance/allowance refresh workaround cp-7.69.0#27166
joaoloureirop merged 1 commit into
release/7.69.0from
runway-cherry-pick-7.69.0-1772842910

Conversation

@runway-github

@runway-github runway-github Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Description

Reverts #26954.

Polymarket has resolved the underlying CLOB infrastructure issue that
was causing intermittent not enough balance / allowance 400 errors
during order placement. The temporary refreshBalanceAllowance()
workaround (calling GET /balance-allowance/update before each order)
is no longer needed and is removed here.

Changes:

  • utils.ts: Remove refreshBalanceAllowance() utility and related
    HMAC auth logic
  • PolymarketProvider.ts: Remove the preflight refresh call from
    placeOrder()
  • utils.test.ts: Remove associated unit tests
  • PolymarketProvider.test.ts: Remove associated integration tests

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: Polymarket order placement without refresh workaround

  Scenario: user places a BUY order on a prediction market
    Given the user has USDC deposited in their Polymarket proxy wallet

    When user places a BUY order on any market
    Then the order completes successfully without a preflight refresh call

  Scenario: user places a SELL order on a prediction market
    Given the user holds outcome tokens for a market

    When user places a SELL order
    Then the order completes successfully without a preflight refresh call

Screenshots/Recordings

N/A — no UI changes

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Changes Polymarket order submission behavior by removing a preflight
balance/allowance refresh; if the upstream CLOB issue is not fully
resolved, this could reintroduce intermittent order failures under load.

Overview
Removes the temporary Polymarket CLOB balance/allowance refresh
workaround by deleting refreshBalanceAllowance from utils.ts and
dropping the pre-submit call in PolymarketProvider.placeOrder().

Cleans up the associated unit/integration coverage by removing mocks
and test cases that asserted the refresh call ordering and failure
handling.

Written by Cursor
Bugbot
for commit
db50f7d. This will update automatically
on new commits. Configure
here.

[8099e72](https://github.com/MetaMask/metamask-mobile/commit/8099e7287489d8e73c8ea0ca4ada7ee5675d53a9)

…/allowance refresh workaround cp-7.69.0 (#27162)

## **Description**

Reverts #26954.

Polymarket has resolved the underlying CLOB infrastructure issue that
was causing intermittent `not enough balance / allowance` 400 errors
during order placement. The temporary `refreshBalanceAllowance()`
workaround (calling `GET /balance-allowance/update` before each order)
is no longer needed and is removed here.

### Changes:
- **`utils.ts`**: Remove `refreshBalanceAllowance()` utility and related
HMAC auth logic
- **`PolymarketProvider.ts`**: Remove the preflight refresh call from
`placeOrder()`
- **`utils.test.ts`**: Remove associated unit tests
- **`PolymarketProvider.test.ts`**: Remove associated integration tests

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: Polymarket order placement without refresh workaround

  Scenario: user places a BUY order on a prediction market
    Given the user has USDC deposited in their Polymarket proxy wallet

    When user places a BUY order on any market
    Then the order completes successfully without a preflight refresh call

  Scenario: user places a SELL order on a prediction market
    Given the user holds outcome tokens for a market

    When user places a SELL order
    Then the order completes successfully without a preflight refresh call
```

## **Screenshots/Recordings**

N/A — no UI changes

### **Before**

<!-- N/A -->

### **After**

<!-- N/A -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes Polymarket order submission behavior by removing a preflight
balance/allowance refresh; if the upstream CLOB issue is not fully
resolved, this could reintroduce intermittent order failures under load.
> 
> **Overview**
> Removes the temporary Polymarket CLOB *balance/allowance refresh*
workaround by deleting `refreshBalanceAllowance` from `utils.ts` and
dropping the pre-submit call in `PolymarketProvider.placeOrder()`.
> 
> Cleans up the associated unit/integration coverage by removing mocks
and test cases that asserted the refresh call ordering and failure
handling.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
db50f7d. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner March 7, 2026 00:21
@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Mar 7, 2026
@github-actions github-actions Bot added the size-M label Mar 7, 2026
@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.69.0)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Mar 7, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 0
Value mismatches 6 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@joaoloureirop joaoloureirop enabled auto-merge (squash) March 9, 2026 17:10
@joaoloureirop joaoloureirop merged commit 8fd3eb8 into release/7.69.0 Mar 9, 2026
106 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.69.0-1772842910 branch March 9, 2026 17:11
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 10, 2026
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.69.0 on PR, as PR was cherry-picked in branch 7.69.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants