Skip to content

chore(runway): cherry-pick feat: fix button label for action button clicked event cp-7.69.0#27125

Merged
joaoloureirop merged 1 commit into
release/7.69.0from
runway-cherry-pick-7.69.0-1772800210
Mar 9, 2026
Merged

chore(runway): cherry-pick feat: fix button label for action button clicked event cp-7.69.0#27125
joaoloureirop merged 1 commit into
release/7.69.0from
runway-cherry-pick-7.69.0-1772800210

Conversation

@runway-github

@runway-github runway-github Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Description

The sticky Buy and Sell buttons on the token details page were both
firing ACTION_BUTTON_CLICKED with button_label: "Swap", making it
impossible to distinguish between the two actions in Mixpanel.
Changes:

  • Added an optional buttonLabel param to goToSwaps / goToNativeBridge in
    useSwapBridgeNavigation, falls back to "Swap" so all existing callers
    are unaffected
  • handleBuyPress now passes button_label: "Buy" and
    handleSellPress passes button_label: "Sell"

Changelog

CHANGELOG entry: updated event property for ACTION_BUTTON_CLICKED

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Low risk: changes only analytics event properties by threading an
optional buttonLabel through navigation helpers; swap/bridge
navigation behavior is unchanged due to a default fallback.

Overview
Fixes token details Buy/Sell sticky buttons reporting
ACTION_BUTTON_CLICKED with button_label: "Swap".

useSwapBridgeNavigation now accepts an optional buttonLabel in
goToNativeBridge/goToSwaps and uses it for trackActionButtonClick
(defaulting to the existing Swap label), and useTokenActions passes
the correct localized Buy/Sell labels; tests were updated to assert the
new arguments.

Written by Cursor
Bugbot
for commit
8c1b45d. This will update automatically
on new commits. Configure
here.

[0e76ada](https://github.com/MetaMask/metamask-mobile/commit/0e76ada8f302dec326c13f35bab02efe29b5cf3c)

…licked event cp-7.69.0 (#27117)

## **Description**

The sticky Buy and Sell buttons on the token details page were both
firing ACTION_BUTTON_CLICKED with button_label: "Swap", making it
impossible to distinguish between the two actions in Mixpanel.
Changes:
* Added an optional buttonLabel param to goToSwaps / goToNativeBridge in
useSwapBridgeNavigation, falls back to "Swap" so all existing callers
are unaffected
* `handleBuyPress` now passes `button_label: "Buy"` and
`handleSellPress` passes `button_label: "Sell"`

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: updated event property for ACTION_BUTTON_CLICKED

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: changes only analytics event properties by threading an
optional `buttonLabel` through navigation helpers; swap/bridge
navigation behavior is unchanged due to a default fallback.
> 
> **Overview**
> Fixes token details *Buy*/*Sell* sticky buttons reporting
`ACTION_BUTTON_CLICKED` with `button_label: "Swap"`.
> 
> `useSwapBridgeNavigation` now accepts an optional `buttonLabel` in
`goToNativeBridge`/`goToSwaps` and uses it for `trackActionButtonClick`
(defaulting to the existing Swap label), and `useTokenActions` passes
the correct localized Buy/Sell labels; tests were updated to assert the
new arguments.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8c1b45d. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested review from a team as code owners March 6, 2026 12:30
@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Mar 6, 2026
@github-actions github-actions Bot added the size-S label Mar 6, 2026
@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.69.0)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Mar 6, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 0
Value mismatches 6 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@joaoloureirop joaoloureirop enabled auto-merge (squash) March 9, 2026 17:12
@joaoloureirop joaoloureirop merged commit 2946793 into release/7.69.0 Mar 9, 2026
106 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.69.0-1772800210 branch March 9, 2026 17:12
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 10, 2026
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.69.0 on PR, as PR was cherry-picked in branch 7.69.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-S team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants