chore(runway): cherry-pick feat: fix button label for action button clicked event cp-7.69.0#27125
Merged
joaoloureirop merged 1 commit intoMar 9, 2026
Conversation
…licked event cp-7.69.0 (#27117) ## **Description** The sticky Buy and Sell buttons on the token details page were both firing ACTION_BUTTON_CLICKED with button_label: "Swap", making it impossible to distinguish between the two actions in Mixpanel. Changes: * Added an optional buttonLabel param to goToSwaps / goToNativeBridge in useSwapBridgeNavigation, falls back to "Swap" so all existing callers are unaffected * `handleBuyPress` now passes `button_label: "Buy"` and `handleSellPress` passes `button_label: "Sell"` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: updated event property for ACTION_BUTTON_CLICKED ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: changes only analytics event properties by threading an optional `buttonLabel` through navigation helpers; swap/bridge navigation behavior is unchanged due to a default fallback. > > **Overview** > Fixes token details *Buy*/*Sell* sticky buttons reporting `ACTION_BUTTON_CLICKED` with `button_label: "Swap"`. > > `useSwapBridgeNavigation` now accepts an optional `buttonLabel` in `goToNativeBridge`/`goToSwaps` and uses it for `trackActionButtonClick` (defaulting to the existing Swap label), and `useTokenActions` passes the correct localized Buy/Sell labels; tests were updated to assert the new arguments. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8c1b45d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.69.0) All E2E tests pre-selected. |
|
Contributor
The committed fixture schema is out of date. To update, comment: |
joaoloureirop
approved these changes
Mar 9, 2026
Collaborator
|
No release label on PR. Adding release label release-7.69.0 on PR, as PR was cherry-picked in branch 7.69.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The sticky Buy and Sell buttons on the token details page were both
firing ACTION_BUTTON_CLICKED with button_label: "Swap", making it
impossible to distinguish between the two actions in Mixpanel.
Changes:
useSwapBridgeNavigation, falls back to "Swap" so all existing callers
are unaffected
handleBuyPressnow passesbutton_label: "Buy"andhandleSellPresspassesbutton_label: "Sell"Changelog
CHANGELOG entry: updated event property for ACTION_BUTTON_CLICKED
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
Low risk: changes only analytics event properties by threading an
optional
buttonLabelthrough navigation helpers; swap/bridgenavigation behavior is unchanged due to a default fallback.
Overview
Fixes token details Buy/Sell sticky buttons reporting
ACTION_BUTTON_CLICKEDwithbutton_label: "Swap".useSwapBridgeNavigationnow accepts an optionalbuttonLabelingoToNativeBridge/goToSwapsand uses it fortrackActionButtonClick(defaulting to the existing Swap label), and
useTokenActionspassesthe correct localized Buy/Sell labels; tests were updated to assert the
new arguments.
Written by Cursor
Bugbot for commit
8c1b45d. This will update automatically
on new commits. Configure
here.