Skip to content

chore(runway): cherry-pick fix(predict): make fee exemption logic feature-flag-driven in PredictMarketDetails cp-7.69.0#27100

Merged
joaoloureirop merged 2 commits into
release/7.69.0from
runway-cherry-pick-7.69.0-1772754440
Mar 9, 2026
Merged

chore(runway): cherry-pick fix(predict): make fee exemption logic feature-flag-driven in PredictMarketDetails cp-7.69.0#27100
joaoloureirop merged 2 commits into
release/7.69.0from
runway-cherry-pick-7.69.0-1772754440

Conversation

@runway-github

@runway-github runway-github Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Description

The fee exemption logic in PredictMarketDetails was hardcoded to check
for a 'Middle East' tag label, while PredictController and
PolymarketProvider already used a feature-flag-driven approach via
feeCollection.waiveList. This PR aligns the UI layer with the existing
pattern:

  • parsePolymarketEvents: Switch tag mapping from t.label to
    t.slug so parsed market tags match the slug-based waiveList entries
    used by waiveFees()
  • selectPredictFeeCollectionFlag: New selector that reads the
    predictFeeCollection remote feature flag, falling back to
    DEFAULT_FEE_COLLECTION_FLAG
  • PredictMarketDetails: Replace hardcoded tags?.includes('Middle East') with tags?.some(slug => waiveList.includes(slug)) driven by
    the selector
  • Added defensive optional chaining on tags access for safety

Changelog

CHANGELOG entry: null

Related issues

Fixes:
PRED-736

Manual testing steps

Feature: Fee exemption display on market details

  Scenario: user views a market with a tag in the waiveList
    Given the remote feature flag predictFeeCollection has waiveList containing 'middle-east'
    And a market has the tag slug 'middle-east'

    When user navigates to the market details screen
    Then the fee exemption message is displayed

  Scenario: user views a market without waived tags
    Given the remote feature flag predictFeeCollection has waiveList containing 'middle-east'
    And a market only has tag slugs 'sports' and 'politics'

    When user navigates to the market details screen
    Then the fee exemption message is not displayed

  Scenario: user views a market when waiveList is empty
    Given the remote feature flag predictFeeCollection has an empty waiveList
    And a market has any tags

    When user navigates to the market details screen
    Then the fee exemption message is not displayed

Screenshots/Recordings

Before

N/A — logic change only, no visual diff

After

N/A — logic change only, no visual diff

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Changes Predict market tags from human-readable labels to slugs and
uses remote predictFeeCollection.waiveList to control fee-exemption
UI, which could affect any UI/analytics expecting label-form tags. Logic
is straightforward and covered by updated/additional selector and view
tests.

Overview
Aligns fee-exemption behavior in PredictMarketDetails with the
fee-collection feature flag by replacing the hardcoded 'Middle East'
tag check with a waiveList (slug) match from the new
selectPredictFeeCollectionFlag selector (defaulting to
DEFAULT_FEE_COLLECTION_FLAG).

Updates Polymarket parsing to store market tags as tag slugs
(t.slug) instead of labels, and adjusts tests to validate the new
slug-based exemption behavior plus selector fallbacks when the remote
flag is missing/null/undefined.

Written by Cursor
Bugbot
for commit
daf0e58. This will update automatically
on new commits. Configure
here.

[098426e](https://github.com/MetaMask/metamask-mobile/commit/098426ef658815e4bf1eab578f8e739c2b77e939)

…ture-flag-driven in PredictMarketDetails cp-7.69.0 (#27090)

## **Description**

The fee exemption logic in `PredictMarketDetails` was hardcoded to check
for a `'Middle East'` tag label, while `PredictController` and
`PolymarketProvider` already used a feature-flag-driven approach via
`feeCollection.waiveList`. This PR aligns the UI layer with the existing
pattern:

- **`parsePolymarketEvents`**: Switch tag mapping from `t.label` to
`t.slug` so parsed market tags match the slug-based `waiveList` entries
used by `waiveFees()`
- **`selectPredictFeeCollectionFlag`**: New selector that reads the
`predictFeeCollection` remote feature flag, falling back to
`DEFAULT_FEE_COLLECTION_FLAG`
- **`PredictMarketDetails`**: Replace hardcoded `tags?.includes('Middle
East')` with `tags?.some(slug => waiveList.includes(slug))` driven by
the selector
- Added defensive optional chaining on `tags` access for safety

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:
[PRED-736](https://consensyssoftware.atlassian.net/browse/PRED-736)

## **Manual testing steps**

```gherkin
Feature: Fee exemption display on market details

  Scenario: user views a market with a tag in the waiveList
    Given the remote feature flag predictFeeCollection has waiveList containing 'middle-east'
    And a market has the tag slug 'middle-east'

    When user navigates to the market details screen
    Then the fee exemption message is displayed

  Scenario: user views a market without waived tags
    Given the remote feature flag predictFeeCollection has waiveList containing 'middle-east'
    And a market only has tag slugs 'sports' and 'politics'

    When user navigates to the market details screen
    Then the fee exemption message is not displayed

  Scenario: user views a market when waiveList is empty
    Given the remote feature flag predictFeeCollection has an empty waiveList
    And a market has any tags

    When user navigates to the market details screen
    Then the fee exemption message is not displayed
```

## **Screenshots/Recordings**

### **Before**

N/A — logic change only, no visual diff

### **After**

N/A — logic change only, no visual diff

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes Predict market `tags` from human-readable labels to slugs and
uses remote `predictFeeCollection.waiveList` to control fee-exemption
UI, which could affect any UI/analytics expecting label-form tags. Logic
is straightforward and covered by updated/additional selector and view
tests.
> 
> **Overview**
> Aligns fee-exemption behavior in `PredictMarketDetails` with the
fee-collection feature flag by replacing the hardcoded `'Middle East'`
tag check with a `waiveList` (slug) match from the new
`selectPredictFeeCollectionFlag` selector (defaulting to
`DEFAULT_FEE_COLLECTION_FLAG`).
> 
> Updates Polymarket parsing to store market `tags` as tag **slugs**
(`t.slug`) instead of labels, and adjusts tests to validate the new
slug-based exemption behavior plus selector fallbacks when the remote
flag is missing/null/undefined.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
daf0e58. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner March 5, 2026 23:47
@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Mar 5, 2026
@github-actions github-actions Bot added the size-M label Mar 5, 2026
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.69.0)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Mar 9, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 0
Value mismatches 6 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@joaoloureirop joaoloureirop merged commit 6dedad5 into release/7.69.0 Mar 9, 2026
185 of 188 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.69.0-1772754440 branch March 9, 2026 19:25
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 10, 2026
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.69.0 on PR, as PR was cherry-picked in branch 7.69.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants