chore(runway): cherry-pick fix(predict): make fee exemption logic feature-flag-driven in PredictMarketDetails cp-7.69.0#27100
Merged
joaoloureirop merged 2 commits intoMar 9, 2026
Conversation
…ture-flag-driven in PredictMarketDetails cp-7.69.0 (#27090) ## **Description** The fee exemption logic in `PredictMarketDetails` was hardcoded to check for a `'Middle East'` tag label, while `PredictController` and `PolymarketProvider` already used a feature-flag-driven approach via `feeCollection.waiveList`. This PR aligns the UI layer with the existing pattern: - **`parsePolymarketEvents`**: Switch tag mapping from `t.label` to `t.slug` so parsed market tags match the slug-based `waiveList` entries used by `waiveFees()` - **`selectPredictFeeCollectionFlag`**: New selector that reads the `predictFeeCollection` remote feature flag, falling back to `DEFAULT_FEE_COLLECTION_FLAG` - **`PredictMarketDetails`**: Replace hardcoded `tags?.includes('Middle East')` with `tags?.some(slug => waiveList.includes(slug))` driven by the selector - Added defensive optional chaining on `tags` access for safety ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: [PRED-736](https://consensyssoftware.atlassian.net/browse/PRED-736) ## **Manual testing steps** ```gherkin Feature: Fee exemption display on market details Scenario: user views a market with a tag in the waiveList Given the remote feature flag predictFeeCollection has waiveList containing 'middle-east' And a market has the tag slug 'middle-east' When user navigates to the market details screen Then the fee exemption message is displayed Scenario: user views a market without waived tags Given the remote feature flag predictFeeCollection has waiveList containing 'middle-east' And a market only has tag slugs 'sports' and 'politics' When user navigates to the market details screen Then the fee exemption message is not displayed Scenario: user views a market when waiveList is empty Given the remote feature flag predictFeeCollection has an empty waiveList And a market has any tags When user navigates to the market details screen Then the fee exemption message is not displayed ``` ## **Screenshots/Recordings** ### **Before** N/A — logic change only, no visual diff ### **After** N/A — logic change only, no visual diff ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes Predict market `tags` from human-readable labels to slugs and uses remote `predictFeeCollection.waiveList` to control fee-exemption UI, which could affect any UI/analytics expecting label-form tags. Logic is straightforward and covered by updated/additional selector and view tests. > > **Overview** > Aligns fee-exemption behavior in `PredictMarketDetails` with the fee-collection feature flag by replacing the hardcoded `'Middle East'` tag check with a `waiveList` (slug) match from the new `selectPredictFeeCollectionFlag` selector (defaulting to `DEFAULT_FEE_COLLECTION_FLAG`). > > Updates Polymarket parsing to store market `tags` as tag **slugs** (`t.slug`) instead of labels, and adjusts tests to validate the new slug-based exemption behavior plus selector fallbacks when the remote flag is missing/null/undefined. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit daf0e58. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
joaoloureirop
approved these changes
Mar 9, 2026
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.69.0) All E2E tests pre-selected. |
|
Contributor
The committed fixture schema is out of date. To update, comment: |
joaoloureirop
approved these changes
Mar 9, 2026
Collaborator
|
No release label on PR. Adding release label release-7.69.0 on PR, as PR was cherry-picked in branch 7.69.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The fee exemption logic in
PredictMarketDetailswas hardcoded to checkfor a
'Middle East'tag label, whilePredictControllerandPolymarketProvideralready used a feature-flag-driven approach viafeeCollection.waiveList. This PR aligns the UI layer with the existingpattern:
parsePolymarketEvents: Switch tag mapping fromt.labeltot.slugso parsed market tags match the slug-basedwaiveListentriesused by
waiveFees()selectPredictFeeCollectionFlag: New selector that reads thepredictFeeCollectionremote feature flag, falling back toDEFAULT_FEE_COLLECTION_FLAGPredictMarketDetails: Replace hardcodedtags?.includes('Middle East')withtags?.some(slug => waiveList.includes(slug))driven bythe selector
tagsaccess for safetyChangelog
CHANGELOG entry: null
Related issues
Fixes:
PRED-736
Manual testing steps
Screenshots/Recordings
Before
N/A — logic change only, no visual diff
After
N/A — logic change only, no visual diff
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Changes Predict market
tagsfrom human-readable labels to slugs anduses remote
predictFeeCollection.waiveListto control fee-exemptionUI, which could affect any UI/analytics expecting label-form tags. Logic
is straightforward and covered by updated/additional selector and view
tests.
Overview
Aligns fee-exemption behavior in
PredictMarketDetailswith thefee-collection feature flag by replacing the hardcoded
'Middle East'tag check with a
waiveList(slug) match from the newselectPredictFeeCollectionFlagselector (defaulting toDEFAULT_FEE_COLLECTION_FLAG).Updates Polymarket parsing to store market
tagsas tag slugs(
t.slug) instead of labels, and adjusts tests to validate the newslug-based exemption behavior plus selector fallbacks when the remote
flag is missing/null/undefined.
Written by Cursor
Bugbot for commit
daf0e58. This will update automatically
on new commits. Configure
here.