Skip to content

feat: MUSD-394 add generic transaction fee row to conversion confirmations#27091

Merged
Matt561 merged 2 commits into
mainfrom
feat/musd-394-add-generic-transaction-fee-row-to-conversion-confirmations
Mar 5, 2026
Merged

feat: MUSD-394 add generic transaction fee row to conversion confirmations#27091
Matt561 merged 2 commits into
mainfrom
feat/musd-394-add-generic-transaction-fee-row-to-conversion-confirmations

Conversation

@Matt561

@Matt561 Matt561 commented Mar 5, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Replace the mUSD-specific NetworkFeeRow with the generic TransactionFeeRow on conversion confirmations, and update the transaction fee tooltip copy to clarify that no MetaMask fee applies.

Changelog

CHANGELOG entry: replaced mUSD conversion-specific network fee row with the generic transaction fee row and updated fee tooltip copy

Related issues

Fixes: MUSD-394: Add generic "Transaction Fee" row to conversion confirmations

Manual testing steps

Feature: Generic transaction fee row for mUSD conversions

  Scenario: user views fee breakdown on mUSD conversion confirmation
    Given user is on the mUSD conversion confirmation screen

    When user views the fee details
    Then the generic transaction fee row is displayed instead of a network-fee-only row

Screenshots/Recordings

Before

mUSD conversions only displayed the "Network Fee"

After

Custom conversion input

image image

"Max" convert bottom sheet

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only confirmation changes to fee row rendering and tooltip copy; main risk is mismatched testIDs or fee display expectations in mUSD conversion flows.

Overview
mUSD conversion confirmations now use the generic TransactionFeeRow instead of the mUSD-specific NetworkFeeRow, so conversions show the same combined transaction fee total (network + provider + MetaMask) and tooltip breakdown as other pay flows.

Removes the ConfirmationRowComponentIDs.NETWORK_FEE selector and deletes the associated musdConversion network-fee row/skeleton tests; updates English tooltip copy to clarify no MetaMask fee applies for mUSD conversions (and fixes mUSD casing in the predict-withdraw tooltip).

Written by Cursor Bugbot for commit dd076d6. This will update automatically on new commits. Configure here.

@Matt561 Matt561 requested a review from a team as a code owner March 5, 2026 20:27
@Matt561 Matt561 added No QA Needed Apply this label when your PR does not need any QA effort. team-earn labels Mar 5, 2026
@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-S label Mar 5, 2026
cursor[bot]
cursor Bot reviewed Mar 5, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread locales/languages/en.json Outdated
@Matt561 Matt561 force-pushed the feat/musd-394-add-generic-transaction-fee-row-to-conversion-confirmations branch from d3746bc to dd076d6 Compare March 5, 2026 20:33
@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmations, SmokePredictions, SmokeTrade
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes modify the BridgeFeeRow component in the confirmations UI by removing the special NetworkFeeRow rendering for musdConversion transaction types. Key changes:

  1. bridge-fee-row.tsx: Removes the NetworkFeeRow component and the NETWORK_FEE_ONLY_TYPES constant. The conditional that showed NetworkFeeRow for musdConversion transactions is removed - now all transaction types use TransactionFeeRow.

  2. ConfirmationView.testIds.ts: Removes the NETWORK_FEE test ID constant since the component is removed.

  3. locales/languages/en.json: Updates tooltip text for predictions - fixes "MUSD" to "mUSD" capitalization and adds clarifying text about no MetaMask fee for mUSD conversion.

The BridgeFeeRow component is used in:

  • musd-max-conversion-info.tsx (mUSD conversion flow - part of Predictions)
  • custom-amount-info.tsx (used in various confirmation flows)
  • Transaction details for bridge operations

Selected tags:

  • SmokeConfirmations: The changes directly affect confirmation UI components and test IDs
  • SmokePredictions: mUSD conversion is part of the predictions feature, and locale changes affect predictions tooltips
  • SmokeTrade: BridgeFeeRow is used in bridge/swap confirmation flows, and SmokeTrade tests bridge functionality

Performance Test Selection:
These changes remove a conditional branch and a UI component (NetworkFeeRow) from the BridgeFeeRow component. This is a simplification that removes code rather than adding complexity. The changes don't affect rendering performance, data loading, or any critical performance paths. No performance tests are needed.

View GitHub Actions results

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 0
Value mismatches 7 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@sonarqubecloud

sonarqubecloud Bot commented Mar 5, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Matt561 Matt561 added this pull request to the merge queue Mar 5, 2026
Merged via the queue into main with commit 903489d Mar 5, 2026
95 checks passed
@Matt561 Matt561 deleted the feat/musd-394-add-generic-transaction-fee-row-to-conversion-confirmations branch March 5, 2026 21:57
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 5, 2026
@metamaskbot metamaskbot added the release-7.70.0 Issue or pull request that will be included in release 7.70.0 label Mar 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.70.0 Issue or pull request that will be included in release 7.70.0 size-S team-earn

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Matt561 @matthewwalsh0 @metamaskbot