Skip to content

chore: Bump snaps-controllers cp-7.67.2 cp-7.67.3#26992

Merged
FrederikBolding merged 1 commit into
mainfrom
fb/snaps-persist-mitigation
Mar 4, 2026
Merged

chore: Bump snaps-controllers cp-7.67.2 cp-7.67.3#26992
FrederikBolding merged 1 commit into
mainfrom
fb/snaps-persist-mitigation

Conversation

@FrederikBolding

@FrederikBolding FrederikBolding commented Mar 4, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Member

Description

Bump snaps-controllers to the latest version which includes a mitigation for production issues where the source code of Snaps is unavailable.

Changelog

CHANGELOG entry: Fixed an issue with running Snaps

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Updates a core Snaps dependency used at runtime; even a patch bump can affect Snap execution/permissions and should be regression-tested with common Snaps flows.

Overview
Bumps @metamask/snaps-controllers from ^18.0.1 to ^18.0.2 (with corresponding yarn.lock updates) to pick up the latest fixes.

Includes a small transitive dependency update within that package (notably @metamask/json-rpc-engine to ^10.2.3).

Written by Cursor Bugbot for commit 67b823f. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-core-platform Core Platform team label Mar 4, 2026
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: 100%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/snaps-controllers. Running all tests.

Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/snaps-controllers. Running all tests.

View GitHub Actions results

@socket-security

socket-security Bot commented Mar 4, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​snaps-controllers@​18.0.1 ⏵ 18.0.271 -2910076 -2496 -450 -50

View full report

@FrederikBolding FrederikBolding marked this pull request as ready for review March 4, 2026 13:33
@sonarqubecloud

sonarqubecloud Bot commented Mar 4, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 60
Missing keys 0
Type mismatches 0
Value mismatches 6 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@FrederikBolding FrederikBolding added this pull request to the merge queue Mar 4, 2026
Merged via the queue into main with commit 4b57dcd Mar 4, 2026
300 of 305 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-persist-mitigation branch March 4, 2026 16:15
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 4, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 4, 2026
@chloeYue chloeYue changed the title chore: Bump snaps-controllers cp-7.67.2 chore: Bump snaps-controllers cp-7.67.2 cp-7.67.3 Mar 5, 2026
@metamaskbot metamaskbot added release-7.68.0 Issue or pull request that will be included in release 7.68.0 and removed release-7.69.0 Issue or pull request that will be included in release 7.69.0 labels Mar 6, 2026
@metamaskbot

metamaskbot commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator

Missing release label release-7.68.0 on PR. Adding release label release-7.68.0 on PR and removing other release labels(release-7.69.0), as PR was cherry-picked in branch 7.68.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees

No one assigned

Labels

release-7.68.0 Issue or pull request that will be included in release 7.68.0 size-XS team-core-platform Core Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FrederikBolding @metamaskbot @Mrtenz @vpintorico