Skip to content

fix: charting library url#26969

Merged
sahar-fehri merged 3 commits into
mainfrom
fix/add-advanced-charts-advanced-url
Mar 6, 2026
Merged

fix: charting library url#26969
sahar-fehri merged 3 commits into
mainfrom
fix/add-advanced-charts-advanced-url

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented Mar 4, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Fix charting library url config

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low-risk configuration-only change, but a missing/incorrect MM_CHARTING_LIBRARY_URL secret/value could cause builds or OTA updates to use the wrong charting assets.

Overview
Fixes charting library URL configuration by introducing MM_CHARTING_LIBRARY_URL as a first-class env var across the build system.

The OTA push workflow (push-eas-update.yml) now injects MM_CHARTING_LIBRARY_URL from GitHub secrets, builds.yml defines the default URL, and scripts/build.sh exports it into the generated .env for Expo update/build steps.

Written by Cursor Bugbot for commit 18c053a. This will update automatically on new commits. Configure here.

@sahar-fehri sahar-fehri requested review from a team as code owners March 4, 2026 09:15
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]
cursor Bot reviewed Mar 4, 2026
View reviewed changes
Comment thread builds.yml Outdated
cursor[bot]
cursor Bot reviewed Mar 4, 2026
View reviewed changes
Comment thread builds.yml
@sahar-fehri sahar-fehri enabled auto-merge March 6, 2026 08:15
@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are purely build/CI configuration changes that add a new environment variable MM_CHARTING_LIBRARY_URL for the TradingView charting library:

  1. .github/workflows/push-eas-update.yml: Adds the secret to the EAS update workflow
  2. builds.yml: Adds a default public URL for the charting library
  3. scripts/build.sh: Adds the variable to the list of env vars exported to .env

The AdvancedChart component that uses this environment variable is not yet integrated into the main application - it only exists in its own directory with unit tests. No existing E2E tests would be affected by this change since:

  • No application logic is modified
  • No UI components are changed
  • The charting library component is not yet used in any user-facing features
  • This is an additive change (new env var) not a modification of existing behavior

No E2E tests are needed for these infrastructure changes.

Performance Test Selection:
These changes only add a new environment variable for a charting library URL. They don't affect app runtime performance, UI rendering, data loading, or any user flows. The AdvancedChart component that uses this variable is not yet integrated into the app, so there's no performance impact to measure.

View GitHub Actions results

cursor[bot]
cursor Bot reviewed Mar 6, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread .github/workflows/push-eas-update.yml
QUICKNODE_POLYGON_URL: ${{ secrets.QUICKNODE_POLYGON_URL }}
QUICKNODE_BSC_URL: ${{ secrets.QUICKNODE_BSC_URL }}
QUICKNODE_SEI_URL: ${{ secrets.QUICKNODE_SEI_URL }}
MM_CHARTING_LIBRARY_URL: ${{ secrets.MM_CHARTING_LIBRARY_URL }}

@cursor cursor Bot Mar 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EAS workflow sources public URL from secrets

Medium Severity

In builds.yml, MM_CHARTING_LIBRARY_URL is defined as a public env var in _public_envs with a hardcoded URL value. However, in push-eas-update.yml, it's sourced via ${{ secrets.MM_CHARTING_LIBRARY_URL }}. All other public (non-secret) env vars in this workflow are set as literal values (e.g., RAMP_INTERNAL_BUILD: 'true'). If this GitHub secret isn't configured, the variable will silently resolve to an empty string in EAS update builds, breaking the charting library feature.

Additional Locations (1)

Fix in Cursor Fix in Web

@sonarqubecloud

sonarqubecloud Bot commented Mar 6, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Cal-L
Cal-L approved these changes Mar 6, 2026
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahar-fehri sahar-fehri added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit 88ebfed Mar 6, 2026
63 checks passed
@sahar-fehri sahar-fehri deleted the fix/add-advanced-charts-advanced-url branch March 6, 2026 18:11
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 6, 2026
@metamaskbot metamaskbot added the release-7.70.0 Issue or pull request that will be included in release 7.70.0 label Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@Cal-L Cal-L Cal-L approved these changes

@weitingsun weitingsun weitingsun approved these changes

Assignees

No one assigned

Labels

release-7.70.0 Issue or pull request that will be included in release 7.70.0 size-XS team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sahar-fehri @Cal-L @weitingsun @metamaskbot