Description

If the user is on a send confirmation and the app goes idle until the device and MetaMask lock, after unlocking they no longer see that confirmation. If they then start a new send, the UI can show the previous confirmation instead of the new one, because the old approval was never rejected and remains first in the pending list.

Solution
When the app locks, reject all pending approvals by calling ApprovalController.clear(providerErrors.userRejectedRequest()) in the lock saga, before navigating to the lock screen. That way there are no stale confirmations after unlock, and any new send shows the correct confirmation.

Changes

• app/store/sagas/index.ts: In appLockStateMachine, after handling LOCKED_APP, clear pending approvals via Engine.context.ApprovalController.clear(...) inside try/catch, then navigate to LOCK_SCREEN. Log and ignore errors so navigation still runs.
• app/store/sagas/sagas.test.ts: Add ApprovalController with clear to the Engine mock; add tests that clear is called with userRejectedRequest() when the app locks and that navigation to LOCK_SCREEN still happens when clear throws.

Changelog

CHANGELOG entry: Fixed issue of confirmation not rejecting when app locks

Related issues

Fixes: #26320

Manual testing steps

Feature: Transaction Confirmation Persistence After Lock

  Scenario: Stale confirmation displayed after device lock timeout and new transaction
    Given the user has MetaMask open and unlocked on the home screen
    # First transaction
    When user initiates a send transaction
    And user reaches the confirmation screen
    # Lock timeout
    And user allows the phone to idle until device and MetaMask lock
    And user unlocks the phone
    And user unlocks MetaMask
    Then the confirmation screen should no longer be open
    # Second transaction - bug occurs
    When user initiates a different send transaction
    And user reaches the confirmation screen
    Then the confirmation shown should be for the previous transaction instead of the current one

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.