Skip to content

chore: Polish list item styling for consistency#26892

Merged
amandaye0h merged 1 commit into
mainfrom
home-list-title/qa
Mar 3, 2026
Merged

chore: Polish list item styling for consistency#26892
amandaye0h merged 1 commit into
mainfrom
home-list-title/qa

Conversation

@amandaye0h

@amandaye0h amandaye0h commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Description

Inconsistencies addressed

  • DeFi list item title was 20px
  • Token List Item title weight was bold

Improvements

  • DeFi list item title updated to 16px, same as all other list items
  • Token List Item title weight reduced to medium

Changes approved by @mmragkandala

Changelog

CHANGELOG entry: null - minor UI fix

Related issues

Fixes:

Manual testing steps

Feature: List item typography consistency (DeFi and Token list)

  Scenario: user views DeFi and token list items with updated text styling
    Given the user has DeFi positions and/or tokens in their wallet
    When the user opens the Wallet tab and views the token list or DeFi section
    Then DeFi protocol names and values use BodyMDMedium (16px)
    And token list item titles (asset names) use medium weight instead of bold
    And list content remains readable with consistent hierarchy

Screenshots/Recordings

Before

Screenshot 2026-03-03 at 9 11 01 PM

After

Screenshot 2026-03-03 at 9 11 13 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk visual-only changes that adjust text variants/weights; no logic, data, or navigation behavior is modified.

Overview
Aligns wallet list item typography for consistency.

In DeFiPositionsListItem, changes the protocol name and USD value text from BodyLGMedium to BodyMDMedium (smaller size). In TokenListItemV2, changes the token title text from BodyMDBold to BodyMDMedium (reduced weight).

Written by Cursor Bugbot for commit b2c2ffa. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are purely cosmetic text styling modifications:

  1. DeFiPositionsListItem.tsx: Changed text variant from BodyLGMedium to BodyMDMedium for protocol name and balance text
  2. TokenListItemV2.tsx: Changed text variant from BodyMDBold to BodyMDMedium for asset name text

These changes:

  • Only modify font size/weight styling (TextVariant)
  • Don't change any component logic, props, or structure
  • Don't affect data flow, state management, or user interactions
  • Don't change text content, only visual presentation

E2E tests verify functionality, element visibility, and text content - not font styling. Since the text content remains unchanged and all component functionality is preserved, these visual styling changes won't cause any E2E test failures.

No E2E tags are needed because:

  • The DeFi test (SmokeNetworkAbstractions) checks for text content like "Aave V3", "$14.74" which remains unchanged
  • Token list tests check for token visibility and interactions, not font styling
  • All assertions in related tests verify content/visibility, not CSS styling

Performance Test Selection:
These changes only modify text variant styling (font size/weight) in two UI components. The changes don't affect: list rendering logic, data loading, state management, component lifecycle, or any computational operations. Text variant changes have negligible performance impact as they're just CSS property changes. No performance tests are needed for these purely cosmetic styling adjustments.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Mar 3, 2026

Copy link
Copy Markdown

@amandaye0h amandaye0h marked this pull request as ready for review March 3, 2026 13:47
@amandaye0h amandaye0h requested a review from a team as a code owner March 3, 2026 13:47
@amandaye0h amandaye0h added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 5e8b02b Mar 3, 2026
92 of 95 checks passed
@amandaye0h amandaye0h deleted the home-list-title/qa branch March 3, 2026 14:18
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 3, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-XS team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants