refactor(analytics): PR A1 move SegmentPersistor, PrivacyPlugin, constants, whenEngineReady, snapKeyring to app/util/analytics by NicolasMassart · Pull Request #26891 · MetaMask/metamask-mobile

NicolasMassart · 2026-03-03T12:59:35Z

Description

Part of the analytics cleanup workstream (#26686).

Moves infrastructure files out of app/core/Analytics/ into app/util/analytics/
Renames files to drop the MetaMetrics prefix:
- MetaMetricsPrivacySegmentPlugin → privacySegmentPlugin
- MetaMetrics.constants → constants
Renames the exported constant METAMETRICS_ANONYMOUS_ID → ANALYTICS_ANONYMOUS_ID
Updates import paths
Adds a previously missing whenEngineReady.test.ts

Files scheduled for deletion in later PRs (e.g. MetaMetrics.ts) are intentionally left untouched.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #26810

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Moderate risk because it rewires import paths and constants across analytics, Engine readiness polling, and Segment setup used at runtime; mistakes could break analytics initialization or cause lingering timers, though behavior is intended to be unchanged and is now covered by new tests.

Overview
Refactors analytics infrastructure by moving whenEngineReady, Segment persistence (segmentPersistor), the privacy Segment plugin, and the anonymous-id constant out of core/Analytics into util/analytics, including renaming METAMETRICS_ANONYMOUS_ID to ANALYTICS_ANONYMOUS_ID.

Updates runtime imports (e.g., analytics.ts, platform-adapter.ts, OAuthService.ts, SnapKeyring.ts) and a broad set of Jest tests/global test setup to mock the new module paths, and adds a dedicated whenEngineReady unit test to validate retry/backoff behavior.

^{Written by Cursor Bugbot for commit 2737a6e. This will update automatically on new commits. Configure here.}

…tants, whenEngineReady, snapKeyring to app/util/analytics

github-actions · 2026-03-03T12:59:45Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…SelectorList tests

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

github-actions · 2026-03-09T11:10:03Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeIdentity, SmokeAccounts, SmokeWalletPlatform, SmokeNetworkExpansion, SmokeConfirmations, FlaskBuildTests
Selected Performance tags: None (no tests recommended)
Risk Level: high
AI Confidence: 70%

click to see 🤖 AI reasoning details

E2E Test Selection:
This PR introduces changes across several core runtime modules:

SnapKeyring (app/core/SnapKeyring/SnapKeyring.ts)
- Directly impacts Snaps-managed accounts and keyring behavior.
- SnapKeyring is foundational for snap-derived accounts (including non-EVM chains like Solana).
- High impact area because keyring changes affect account creation, signing, and account exposure to dApps.
- Requires running FlaskBuildTests (Snaps lifecycle and provider integration).
- Also impacts multi-chain/Solana flows → include SmokeNetworkExpansion.
- Since Solana transactions/signing hit confirmations, include SmokeConfirmations.
- Keyring changes may affect account listing and management → include SmokeAccounts.
OAuthService (app/core/OAuthService/OAuthService.ts)
- Tied to identity and account sync flows.
- Changes here can affect profile sync, login state, and multi-SRP synchronization.
- Requires SmokeIdentity.
- Per tag dependency rules, when selecting SmokeIdentity also select SmokeAccounts and SmokeWalletPlatform.
Analytics-related changes (MetaMetrics.constants.ts, analytics.ts, SegmentPersistor.ts, privacySegmentPlugin.ts, platform-adapter.ts, whenEngineReady.ts)
- These are cross-cutting concerns triggered during Engine readiness and user flows.
- While primarily telemetry, they are wired into Engine lifecycle and could indirectly affect app startup, account events, or Snap tracking.
- Covered indirectly by broad functional tags (SmokeWalletPlatform, SmokeAccounts, SmokeIdentity, SmokeNetworkExpansion).
EngineService.test.ts and analytics-controller/platform-adapter.ts
- Engine-related integration layer (though changes appear analytics-focused).
- Given Engine centrality, risk is elevated.

Because changes touch core key management (SnapKeyring), identity/OAuth, and Engine-integrated analytics, the overall risk is HIGH with potential cross-domain impact.

Selected tags ensure coverage of:

Account management and SRP flows (SmokeAccounts)
Identity and sync flows (SmokeIdentity)
Core wallet platform and lifecycle (SmokeWalletPlatform)
Solana & multi-chain provider behavior (SmokeNetworkExpansion)
Transaction/signature confirmations (SmokeConfirmations)
Snaps lifecycle and provider APIs (FlaskBuildTests)

No Trade/Perps/Predictions/Card/Ramps specific logic was modified, so those tags are excluded to minimize unnecessary execution.

Performance Test Selection:
Changes are focused on analytics, OAuth service logic, and Snap keyring behavior. There are no UI rendering changes, list virtualization updates, onboarding/login performance modifications, swap/perps performance changes, or Engine initialization performance refactors. Therefore, no dedicated performance test suites are required for this PR.

View GitHub Actions results

codecov-commenter · 2026-03-09T11:33:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.70%. Comparing base (0ea672c) to head (2737a6e).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #26891      +/-   ##
==========================================
+ Coverage   81.68%   81.70%   +0.01%     
==========================================
  Files        4652     4654       +2     
  Lines      121697   121764      +67     
  Branches    26740    26754      +14     
==========================================
+ Hits        99412    99487      +75     
+ Misses      15369    15359      -10     
- Partials     6916     6918       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sonarqubecloud · 2026-03-09T11:35:33Z

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
99.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-03-09T11:36:29Z

✅ E2E Fixture Validation — Schema is up to date
8 value mismatches detected (expected — fixture represents an existing user).
View details

grvgoel81

lgtm

gantunesr

Approved for Accounts CO,

- app/component-library/components-temp/MultichainAccounts/MultichainAccountSelectorList/MultichainAccountSelectorList.test.tsx
- app/core/SnapKeyring/SnapKeyring.test.ts
- app/core/SnapKeyring/SnapKeyring.ts

MarioAslau

LGTM

refactor(analytics): PR A1 move SegmentPersistor, PrivacyPlugin, cons…

b235091

…tants, whenEngineReady, snapKeyring to app/util/analytics

NicolasMassart added the team-mobile-platform Mobile Platform team label Mar 3, 2026

NicolasMassart self-assigned this Mar 3, 2026

github-actions Bot added the size-M label Mar 3, 2026

NicolasMassart added 2 commits March 3, 2026 19:19

fix(tests): update mock path for whenEngineReady in MultichainAccount…

b109dae

…SelectorList tests

fix(tests): update mock path for whenEngineReady in various test files

4c4e58a

NicolasMassart marked this pull request as ready for review March 4, 2026 13:02

Merge branch 'main' into refactor/26810_a1-platform_move-files

e2c61d0

NicolasMassart requested review from a team as code owners March 4, 2026 13:02

cursor Bot reviewed Mar 4, 2026

View reviewed changes

Comment thread app/util/analytics/whenEngineReady.test.ts

Merge branch 'main' into refactor/26810_a1-platform_move-files

37fac56

NicolasMassart enabled auto-merge March 4, 2026 16:30

NicolasMassart and others added 2 commits March 6, 2026 14:58

Merge branch 'main' into mm-a1

a6886b5

Merge branch 'main' into refactor/26810_a1-platform_move-files

2737a6e

NicolasMassart added this to PR review queue Mar 9, 2026

NicolasMassart moved this to Needs dev review in PR review queue Mar 9, 2026

Brunonascdev approved these changes Mar 9, 2026

View reviewed changes

grvgoel81 approved these changes Mar 9, 2026

View reviewed changes

gantunesr reviewed Mar 9, 2026

View reviewed changes

gantunesr approved these changes Mar 9, 2026

View reviewed changes

himanshuchawla009 approved these changes Mar 9, 2026

View reviewed changes

MarioAslau approved these changes Mar 10, 2026

View reviewed changes

PatrykLucka approved these changes Mar 10, 2026

View reviewed changes

NicolasMassart added this pull request to the merge queue Mar 10, 2026

github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 10, 2026

Merged via the queue into main with commit e1d9a57 Mar 10, 2026
115 checks passed

NicolasMassart deleted the refactor/26810_a1-platform_move-files branch March 10, 2026 11:24

github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Mar 10, 2026

github-actions Bot locked and limited conversation to collaborators Mar 10, 2026

metamaskbot added the release-7.70.0 Issue or pull request that will be included in release 7.70.0 label Mar 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(analytics): PR A1 move SegmentPersistor, PrivacyPlugin, constants, whenEngineReady, snapKeyring to app/util/analytics#26891

refactor(analytics): PR A1 move SegmentPersistor, PrivacyPlugin, constants, whenEngineReady, snapKeyring to app/util/analytics#26891
NicolasMassart merged 7 commits into
mainfrom
refactor/26810_a1-platform_move-files

NicolasMassart commented Mar 3, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

codecov-commenter commented Mar 9, 2026

Uh oh!

sonarqubecloud Bot commented Mar 9, 2026

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

grvgoel81 left a comment

Uh oh!

gantunesr left a comment

Uh oh!

MarioAslau left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

NicolasMassart commented Mar 3, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 9, 2026

🔍 Smart E2E Test Selection

Uh oh!

codecov-commenter commented Mar 9, 2026

Codecov Report

Uh oh!

sonarqubecloud Bot commented Mar 9, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

grvgoel81 left a comment

Choose a reason for hiding this comment

Uh oh!

gantunesr left a comment

Choose a reason for hiding this comment

Uh oh!

MarioAslau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

NicolasMassart commented Mar 3, 2026 •

edited by cursor Bot

Loading