Skip to content

chore: bump core dependencies#26849

Merged
hmalik88 merged 31 commits into
mainfrom
hm/integrate-1449
Mar 12, 2026
Merged

chore: bump core dependencies#26849
hmalik88 merged 31 commits into
mainfrom
hm/integrate-1449

Conversation

@hmalik88

@hmalik88 hmalik88 commented Mar 3, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Updated the following dependencies (with required integration work, if any):

  1. @metamask/accounts-controller - Update getInternalAccountByAddress selector.
  2. @metamask/preferences-controller - Update PreferencesController state type.
  3. @metamask/account-tree-controller
  4. @metamask/delegation-controller
  5. @metamask/multichain-network-controller
  6. @metamask/multichain-transactions-controller

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Manual testing steps

  1. Build from branch.
  2. Create an account
  3. Verify nothing breaks

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Bumps multiple core controller dependencies and changes account lookup to rely on the new AccountsController.state.accountIdByAddress map, which could affect any code paths that resolve accounts by address if the map is missing or stale.

Overview
Updates several MetaMask core dependencies (notably @metamask/accounts-controller to 37.0.0 and @metamask/account-tree-controller to 5.x).

Adopts the new AccountsController state field accountIdByAddress by adding it to default/fixture state and updating getInternalAccountByAddress to resolve accounts via this map (with lowercase fallback) instead of scanning all accounts.

Adjusts tests, fixtures, and snapshots to include accountIdByAddress, and updates migration test typings to reflect that this field is non-persisted.

Written by Cursor Bugbot for commit bc2a1ab. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Mar 3, 2026
@github-actions github-actions Bot added the size-S label Mar 3, 2026
@hmalik88 hmalik88 changed the title chore: bump @metamask/accounts-controller chore: bump core dependencies Mar 9, 2026
@github-actions github-actions Bot added size-M and removed size-S labels Mar 9, 2026
@socket-security

socket-security Bot commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​multichain-transactions-controller@​7.0.1 ⏵ 7.0.2981007496 +2100
Updatednpm/​@​metamask/​delegation-controller@​2.0.1 ⏵ 2.0.21001007595 +3100

View full report

@hmalik88

hmalik88 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

@metamaskbot update-mobile-fixture

@hmalik88

hmalik88 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

@metamaskbot update-mobile-fixture

cursor[bot]
cursor Bot reviewed Mar 11, 2026
View reviewed changes
Comment thread app/util/address/index.ts
@codecov-commenter

codecov-commenter commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.87%. Comparing base (8ff2a61) to head (2e6aeb5).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #26849      +/-   ##
==========================================
- Coverage   81.87%   81.87%   -0.01%     
==========================================
  Files        4691     4691              
  Lines      122285   122283       -2     
  Branches    26949    26951       +2     
==========================================
- Hits       100122   100119       -3     
- Misses      15220    15221       +1     
  Partials     6943     6943

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gantunesr
gantunesr previously approved these changes Mar 12, 2026
View reviewed changes
Cal-L
Cal-L previously approved these changes Mar 12, 2026
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform lgtm

cortisiko
cortisiko previously approved these changes Mar 12, 2026
View reviewed changes
@hmalik88 hmalik88 added this pull request to the merge queue Mar 12, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Mar 12, 2026
@hmalik88 hmalik88 dismissed stale reviews from cortisiko, Cal-L, and gantunesr via d8c82d8 March 12, 2026 16:30
cursor[bot]
cursor Bot reviewed Mar 12, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread app/components/Views/AccountPermissions/AccountPermissions.test.tsx
@github-actions

github-actions Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: 100%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/accounts-controller, @metamask/account-tree-controller, @metamask/delegation-controller, @metamask/multichain-network-controller, @metamask/multichain-transactions-controller. Running all tests.

Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/accounts-controller, @metamask/account-tree-controller, @metamask/delegation-controller, @metamask/multichain-network-controller, @metamask/multichain-transactions-controller. Running all tests.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Mar 12, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

Cal-L
Cal-L approved these changes Mar 12, 2026
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmalik88 hmalik88 added this pull request to the merge queue Mar 12, 2026
Merged via the queue into main with commit 1ea19b6 Mar 12, 2026
286 of 290 checks passed
@hmalik88 hmalik88 deleted the hm/integrate-1449 branch March 12, 2026 19:41
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 12, 2026
@metamaskbot metamaskbot added the release-7.71.0 Issue or pull request that will be included in release 7.71.0 label Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@Cal-L Cal-L Cal-L approved these changes

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

@hjetpoluru hjetpoluru hjetpoluru left review comments

Assignees

No one assigned

Labels

release-7.71.0 Issue or pull request that will be included in release 7.71.0 size-M team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hmalik88 @codecov-commenter @Cal-L @cortisiko @gantunesr @hjetpoluru @metamaskbot