Skip to content

chore: Revert "Skip sonar cloud CI steps for now"#26837

Merged
Cal-L merged 1 commit into
mainfrom
chore/reenable-sonar-cloud
Mar 2, 2026
Merged

chore: Revert "Skip sonar cloud CI steps for now"#26837
Cal-L merged 1 commit into
mainfrom
chore/reenable-sonar-cloud

Conversation

@Cal-L

@Cal-L Cal-L commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This reverts commit b2df46b.

Description

Successful run on this branch - https://github.com/MetaMask/metamask-mobile/actions/runs/22598734111/job/65477896719?pr=26837

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes required CI gating by re-enabling SonarCloud jobs and making the quality gate part of the overall pass/fail status, which could block PRs if SonarCloud is flaky or misconfigured.

Overview
Re-enables SonarCloud analysis in the ci.yml workflow by removing the hard if: false skips and running the sonar-cloud and sonar-cloud-quality-gate-status jobs on non-merge_group events.

Updates the required jobs aggregation so all-jobs-pass now depends on sonar-cloud-quality-gate-status, making SonarCloud quality gate results contribute to the overall CI pass/fail outcome.

Written by Cursor Bugbot for commit 8290967. This will update automatically on new commits. Configure here.

@Cal-L Cal-L requested a review from a team as a code owner March 2, 2026 22:30
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 2, 2026
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change and removed team-mobile-platform Mobile Platform team labels Mar 2, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Mar 2, 2026
@Cal-L Cal-L added the team-mobile-platform Mobile Platform team label Mar 2, 2026
@Cal-L Cal-L enabled auto-merge March 2, 2026 22:33
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes to .github/workflows/ci.yml are purely CI infrastructure changes that re-enable SonarCloud code quality analysis jobs that were previously disabled. Specifically:

  1. The sonar-cloud job is re-enabled (was if: false, now if: ${{ !cancelled() && github.event_name != 'merge_group' }})
  2. The sonar-cloud-quality-gate-status job is similarly re-enabled
  3. The sonar-cloud-quality-gate-status job is added to the all-jobs-pass job's dependencies

These changes:

  • Do NOT modify any application code
  • Do NOT modify any E2E test infrastructure (page objects, fixtures, test files)
  • Do NOT affect any test execution logic
  • Only enable a code quality scanning tool (SonarCloud) in the CI pipeline

SonarCloud is a static code analysis tool that runs independently of E2E tests. Re-enabling it doesn't require E2E test validation since it doesn't change any app behavior or test infrastructure. The E2E tests themselves are not affected by whether SonarCloud runs or not.

Performance Test Selection:
These changes are purely CI workflow infrastructure changes that re-enable SonarCloud code quality analysis. They do not affect any application code, UI components, data loading, state management, or any other aspect that could impact app performance. No performance tests are needed.

View GitHub Actions results

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 2, 2026
cursor[bot]
cursor Bot reviewed Mar 2, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
@sonarqubecloud

sonarqubecloud Bot commented Mar 2, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Cal-L Cal-L added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 56deb1a Mar 2, 2026
116 checks passed
@Cal-L Cal-L deleted the chore/reenable-sonar-cloud branch March 2, 2026 23:18
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 2, 2026
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 2, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

No one assigned

Labels

no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-XS team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Cal-L @MarioAslau @metamaskbot