Skip to content

test: skip full views navigation test in Trending Feed#26786

Merged
cmd-ob merged 1 commit into
mainfrom
skip-trending-test
Mar 2, 2026
Merged

test: skip full views navigation test in Trending Feed#26786
cmd-ob merged 1 commit into
mainfrom
skip-trending-test

Conversation

@cmd-ob

@cmd-ob cmd-ob commented Mar 2, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

  • Skip trending tests to unblock pipeline

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: this only disables a smoke test, reducing CI coverage but not affecting production code paths.

Overview
Disables the Trending Feed smoke test that navigates through each section’s View All full views (and back to the feed) by marking the spec as it.skip, to unblock the pipeline.

Written by Cursor Bugbot for commit 5f8dd44. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Mar 2, 2026
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change is minimal and only affects a single E2E test file (tests/smoke/trending/trending-feed.spec.ts). The modification adds .skip to a test case, effectively disabling the test 'Navigate to all sections full views via View All and return to feed'. This is a test infrastructure change that skips a test - no application code is modified. Since no application functionality is being changed, there's no need to run E2E tests to validate this PR. The test being skipped is likely due to flakiness or maintenance reasons. Running E2E tests would not provide any meaningful validation for this change.

Performance Test Selection:
No application code is changed - only a test file is modified to skip a test. There are no changes that could impact app performance, so no performance tests are needed.

View GitHub Actions results

@cmd-ob cmd-ob added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels Mar 2, 2026
@cmd-ob cmd-ob enabled auto-merge March 2, 2026 14:09
@cmd-ob cmd-ob requested a review from racitores March 2, 2026 14:09
@cmd-ob cmd-ob added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 12f0853 Mar 2, 2026
83 of 87 checks passed
@cmd-ob cmd-ob deleted the skip-trending-test branch March 2, 2026 14:48
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 2, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pnarayanaswamy pnarayanaswamy pnarayanaswamy approved these changes

@racitores racitores Awaiting requested review from racitores

Assignees

No one assigned

Labels

no changelog required No changelog entry is required for this change no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-XS team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmd-ob @pnarayanaswamy @metamaskbot