fix(25760): prevent Ledger connect image from being cut off on iOS cp-7.70.0#26783
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
bddcefc to
cdfded9
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26783 +/- ##
===========================================
- Coverage 81.61% 51.60% -30.01%
===========================================
Files 4598 4619 +21
Lines 120455 121169 +714
Branches 26347 26436 +89
===========================================
- Hits 98307 62530 -35777
- Misses 15258 53409 +38151
+ Partials 6890 5230 -1660 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Tested on iOS on build https://app.bitrise.io/build/66f4578b-75c7-4299-96aa-6f1dc733d1cc?tab=artifacts , the ledger icon is shown as expected. Adding "qa passed" label. |
fa0bed9 to
49d4416
Compare
| minSdkVersion rootProject.ext.minSdkVersion | ||
| targetSdkVersion rootProject.ext.targetSdkVersion | ||
| versionName "7.70.0" | ||
| versionCode 3607 |
There was a problem hiding this comment.
I believe this change is not necessary
| - pr_check_build_cache | ||
| expo_dev_pipeline: | ||
| stages: | ||
| - create_build_dev_expo: {} |
There was a problem hiding this comment.
Why are we changing the bitrise workflow name?
There was a problem hiding this comment.
Not sure why metamaskbot applied these changes
| inputs: | ||
| - deploy_path: ios/build/$RENAMED_ARCHIVE_FILE | ||
| title: Deploy Symbols File | ||
| - deploy-to-bitrise-io@2.2.3: |
There was a problem hiding this comment.
I believe all changes in this file should be reverted
| "\"$(SRCROOT)/MetaMask/System/Library/Frameworks\"", | ||
| ); | ||
| LLVM_LTO = YES; | ||
| MARKETING_VERSION = 7.70.0; |
There was a problem hiding this comment.
We should also revert the changes to this file
There was a problem hiding this comment.
I reverted those changes
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
|
✅ E2E Fixture Validation — Schema is up to date |
|
Description
On iOS, the Ledger connect illustration was cut off when opening the Ledger flow after the keyboard had been shown (e.g. search in Explore, then back). Removed
overflow: 'visible'from the cover image style so the layout no longer gets clipped. Also fixed a typo in LedgerSelectAccount:style-=→style=so the selector container gets its styles.Changelog
CHANGELOG entry: Fixed Ledger connect screen image being cut off on iOS after using the keyboard.
Related issues
Fixes: #25760
Manual testing steps
Feature: Ledger connect screen
Scenario: user opens Ledger connect after using keyboard
Given the app is open and user has been to Explore and opened the search keyboard then navigated back
Note
Low Risk
Low risk, UI-only style tweaks plus a snapshot update; potential impact is limited to Ledger connect/select-account screen layout across devices.
Overview
Prevents the Ledger connect illustration from being clipped (notably on iOS after keyboard interactions) by removing
overflow: 'visible'from theLedgerConnectcover image styling, and updates the Jest snapshot accordingly.Adjusts
LedgerSelectAccountlayout by removingflex: 1fromselectorContainerto ensure the selector section sizes/positions correctly.Written by Cursor Bugbot for commit d6b0203. This will update automatically on new commits. Configure here.