Skip to content

fix: android e2e locally build for arm64-v8a #26774

Merged
tommasini merged 2 commits into
mainfrom
fix/android-e2e-locally
Mar 2, 2026
Merged

fix: android e2e locally build for arm64-v8a #26774
tommasini merged 2 commits into
mainfrom
fix/android-e2e-locally

Conversation

@tommasini

@tommasini tommasini commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Description

Android E2E builds were hardcoded to x86_64 only, which prevented developers on Apple Silicon Macs from running E2E tests locally (arm64 AVDs and physical devices need arm64-v8a).

The fix detects whether the build is running in CI (CI=true) and scopes the architecture restriction accordingly:

  • CI: x86_64 only — unchanged, keeps CI builds fast since GitHub Actions emulators are x86_64.
  • Local: x86_64,arm64-v8a — covers Apple Silicon emulators, Intel Mac emulators, and physical devices.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: Android E2E local build

  Scenario: developer runs E2E build on Apple Silicon Mac
    Given a macOS Apple Silicon machine with an arm64 Android emulator
    When the developer runs the Android E2E build script locally
    Then the APK is built for both x86_64 and arm64-v8a
    And the APK installs successfully on the arm64 emulator

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: a small conditional change to the Android build script that only affects METAMASK_ENVIRONMENT=e2e builds and keeps CI behavior unchanged.

Overview
Android E2E builds now choose React Native architectures based on whether they’re running in CI.

When METAMASK_ENVIRONMENT=e2e, CI continues to build x86_64 only, while local builds produce both x86_64 and arm64-v8a APKs to support Apple Silicon emulators and arm64 devices.

Written by Cursor Bugbot for commit 76e40c5. This will update automatically on new commits. Configure here.

@tommasini tommasini requested a review from a team as a code owner March 2, 2026 12:38
@tommasini tommasini added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run labels Mar 2, 2026
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 2, 2026
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@tommasini tommasini enabled auto-merge March 2, 2026 16:49
@tommasini tommasini added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit f534ceb Mar 2, 2026
105 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 2, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-XS skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants