fix: android e2e locally build for arm64-v8a #26774
Merged
Merged
Conversation
…rs on apple chips machines
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
NicolasMassart
approved these changes
Mar 2, 2026
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Android E2E builds were hardcoded to
x86_64only, which prevented developers on Apple Silicon Macs from running E2E tests locally (arm64 AVDs and physical devices needarm64-v8a).The fix detects whether the build is running in CI (
CI=true) and scopes the architecture restriction accordingly:x86_64only — unchanged, keeps CI builds fast since GitHub Actions emulators are x86_64.x86_64,arm64-v8a— covers Apple Silicon emulators, Intel Mac emulators, and physical devices.Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: a small conditional change to the Android build script that only affects
METAMASK_ENVIRONMENT=e2ebuilds and keeps CI behavior unchanged.Overview
Android E2E builds now choose React Native architectures based on whether they’re running in CI.
When
METAMASK_ENVIRONMENT=e2e, CI continues to buildx86_64only, while local builds produce bothx86_64andarm64-v8aAPKs to support Apple Silicon emulators and arm64 devices.Written by Cursor Bugbot for commit 76e40c5. This will update automatically on new commits. Configure here.