You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Feature: my feature nameScenario: user [verb for user action]Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Note
Low Risk
Low risk UI-only change that swaps the row wrapper component and tweaks padding/accessibility; main risk is minor touch/spacing regressions in the recipient list.
Overview
Fixes the recipient list row rendering in the send/confirmation flow by replacing the design-system ButtonBase wrapper with React Native Pressable.
Updates the row styling to include horizontal padding (px-4) and explicitly sets accessibilityRole="button" while preserving the existing pressed/selected background behavior.
Written by Cursor Bugbot for commit e5b33b4. This will update automatically on new commits. Configure here.
Selected Performance tags: None (no tests recommended)
Risk Level: medium
AI Confidence: 85%
click to see 🤖 AI reasoning details
E2E Test Selection:
The change modifies the Recipient component in the confirmations UI, replacing ButtonBase from the design system with React Native's native Pressable component. This component is used in the send flow for displaying and selecting recipients in the recipient list.
Key changes:
Replaced ButtonBase with Pressable from react-native
Added px-4 padding to the style
Added accessibilityRole="button" for accessibility
The component is used in:
recipient-list.tsx - for displaying recipient lists in send flow
send/recipient/recipient.tsx - for the send recipient screen
The send flow tests (e.g., send-native-token.spec.ts, send-erc20-token.spec.ts) are tagged with SmokeConfirmations and test the complete send flow including recipient selection. While the E2E tests primarily interact with the recipient address input field rather than the recipient list items directly, the visual and interaction behavior of the recipient selection could be affected by this change.
This is a medium-risk change because:
It's a UI component swap that could affect visual appearance and interaction behavior
The testIDs are preserved, so existing tests should still work
The styling change is minor (added padding)
The functionality should remain the same
SmokeConfirmations is the appropriate tag as it covers send flows and transaction confirmations.
Performance Test Selection:
This change is a simple UI component swap (ButtonBase to Pressable) with minor styling adjustments. It does not affect rendering performance, data loading, state management, or any critical performance paths. The change is localized to a single component and does not impact list rendering, app startup, or any performance-sensitive flows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
no-changelogno-changelog Indicates no external facing user changes, therefore no changelog documentation neededrelease-7.69.0Issue or pull request that will be included in release 7.69.0size-XSteam-confirmationsPush issues to confirmations team
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix recipient list display in send flow.
Changelog
CHANGELOG entry:
Related issues
Fixes: #26684
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI-only change that swaps the row wrapper component and tweaks padding/accessibility; main risk is minor touch/spacing regressions in the recipient list.
Overview
Fixes the recipient list row rendering in the send/confirmation flow by replacing the design-system
ButtonBasewrapper with React NativePressable.Updates the row styling to include horizontal padding (
px-4) and explicitly setsaccessibilityRole="button"while preserving the existing pressed/selected background behavior.Written by Cursor Bugbot for commit e5b33b4. This will update automatically on new commits. Configure here.