Skip to content

refactor: Renamed HeaderCompactSearch to HeaderSearch#26743

Merged
brianacnguyen merged 1 commit into
mainfrom
refactor/header-search
Mar 2, 2026
Merged

refactor: Renamed HeaderCompactSearch to HeaderSearch#26743
brianacnguyen merged 1 commit into
mainfrom
refactor/header-search

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Description

This PR renames HeaderCompactSearch to HeaderSearch in app/component-library/components-temp/.

Reason for change: Simplifying the component name; "HeaderSearch" better reflects its purpose (a header with an integrated search field) without the "Compact" qualifier.

What changed:

  1. Component rename

    • Created app/component-library/components-temp/HeaderSearch/ with:
      • HeaderSearch.tsx – main component (screen and inline variants unchanged)
      • HeaderSearch.types.tsHeaderSearchVariant, HeaderSearchProps, HeaderSearchScreenProps, HeaderSearchInlineProps
      • HeaderSearch.test.tsx – tests updated for new name and testIDs (header-search, header-search-inline)
      • HeaderSearch.stories.tsx – Storybook entry "Components Temp / HeaderSearch"
      • index.ts – exports default and types
    • Renamed types: HeaderCompactSearch*HeaderSearch* (e.g. HeaderSearchVariant, HeaderSearchProps).
  2. Removed HeaderCompactSearch

    • Deleted app/component-library/components-temp/HeaderCompactSearch/ (index, types, component, stories, test).
    • Updated .storybook/storybook.requires.js to require HeaderSearch.stories.tsx instead of HeaderCompactSearch.stories.tsx.

No other app code used HeaderCompactSearch; the rename is limited to the component folder and Storybook.

Changelog

This PR is not end-user-facing; it renames an internal header component.

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-497

Manual testing steps

Feature: HeaderCompactSearch renamed to HeaderSearch

  Scenario: Lint and type check pass
    Given the branch is checked out
    When the author runs yarn lint and yarn lint:tsc
    Then both complete without errors

  Scenario: No references to HeaderCompactSearch
    Given the codebase is searched for HeaderCompactSearch
    Then no imports or usages remain

  Scenario: HeaderSearch unit tests pass
    Given the branch is checked out
    When the author runs yarn jest app/component-library/components-temp/HeaderSearch/HeaderSearch.test.tsx
    Then all tests pass

  Scenario: HeaderSearch story renders
    Given Storybook is running
    When the user opens "Components Temp / HeaderSearch"
    Then Screen and Inline stories render as before

Screenshots/Recordings

Before

N/A – component behavior unchanged; only name and file paths changed.

After

N/A – same header-with-search appearance; component is now HeaderSearch.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk rename confined to component-library temp components and Storybook; main risk is missed import/path updates or changed testIDs impacting tests or downstream consumers.

Overview
Renames the temp header-with-search component from HeaderCompactSearch to HeaderSearch, including updating the exported types (Header*Variant/props) and default export.

Updates Storybook registration and stories to the new component name, and adjusts unit tests (including testIDs like header-search/header-search-inline) to match the rename.

Written by Cursor Bugbot for commit 3be9bec. This will update automatically on new commits. Configure here.

@brianacnguyen brianacnguyen self-assigned this Mar 2, 2026
@brianacnguyen brianacnguyen requested a review from a team as a code owner March 2, 2026 05:38
@brianacnguyen brianacnguyen added No QA Needed Apply this label when your PR does not need any QA effort. team-design-system All issues relating to design system in Mobile no changelog required No changelog entry is required for this change labels Mar 2, 2026
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Mar 2, 2026
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR is a pure component rename from HeaderCompactSearch to HeaderSearch within the component library's temporary components folder (app/component-library/components-temp/).

Key findings:

  1. The component has NO external importers - grep searches for both HeaderCompactSearch and HeaderSearch show usage only within the component's own directory (test files, stories, and internal imports)
  2. This is a self-contained component in components-temp that is not yet integrated into any app screens or features
  3. The changes are purely cosmetic/organizational - renaming files and updating internal type names
  4. No functional logic changes were made to the component
  5. The component's own unit tests are included and updated with the rename

Since this component is not used anywhere in the application, no E2E tests can be affected by this change. The storybook.requires.js update is auto-generated and only affects Storybook documentation, not the app itself.

Performance Test Selection:
This is a pure component rename with no functional changes. The HeaderSearch component is not used anywhere in the app (no external importers found), so there is no impact on app performance. The changes are limited to file/type renaming within the component library's temporary components folder.

View GitHub Actions results

@georgewrmarshall georgewrmarshall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice size PR

  • confirmed no remaining instances of HeaderCompactSearch in codebase
Image

@brianacnguyen brianacnguyen added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit f1be99b Mar 2, 2026
88 checks passed
@brianacnguyen brianacnguyen deleted the refactor/header-search branch March 2, 2026 19:33
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 2, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-M team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants