refactor: Removed HeaderStackedStandard from codebase#26742
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…to refactor/rm-header-stacked-standard
…to refactor/rm-header-stacked-standard
…to refactor/rm-header-stacked-standard
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
The changes are UI-only (header component refactoring) and don't change functionality, but they affect the visual layout and structure of these critical account management screens. The snapshot test update confirms structural changes to the UI hierarchy. Given these are important user flows for account management and wallet setup, running the relevant smoke tests is appropriate to verify the UI changes don't break the flows. Performance Test Selection: |
The committed fixture schema is out of date. To update, comment: |
Description
This PR migrates usages of HeaderStackedStandard to HeaderCompactStandard and TitleStandard, then removes the HeaderStackedStandard component from
app/component-library/components-temp/.Reason for change: Preparing to deprecate HeaderStackedStandard. Replacing it with HeaderCompactStandard (button row) + TitleStandard (title block) preserves the same layout and spacings (
px-2on the header row,px-4 pt-1 pb-3on the title section) while using the preferred components.What changed:
View migrations (3 files)
HeaderStackedStandardwithHeaderCompactStandard(back + QR button) andTitleStandard(title + bottomAccessory), props inlined.HeaderCompactStandard(onBack) +TitleStandard(title, bottomAccessory), props inlined.HeaderCompactStandard(backButtonProps) +TitleStandard(title, bottomAccessory), props inlined.twClassName="px-4 pt-1 pb-3"onTitleStandard.Removed HeaderStackedStandard
app/component-library/components-temp/HeaderStackedStandard/(index, types, component, stories, test).require()from.storybook/storybook.requires.js.No other app code used HeaderStackedStandard; removal is limited to the three views above and the component folder.
Changelog
This PR is not end-user-facing; it refactors internal header usage and removes one header component.
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-496
Manual testing steps
Screenshots/Recordings
Before
N/A – layout unchanged; only implementation (component swap) changed.
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-03-01.at.21.23.55.mov
N/A – same header appearance and spacing on the three screens.
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk refactor that swaps a composite header component for two existing components; main risk is minor layout/spacing or header action wiring regressions on the three migrated screens.
Overview
Removes the temporary
HeaderStackedStandardcomponent entirely (component, types, tests, Storybook story) and drops its Storybook registration.Migrates three screens (
ConnectHardware/SelectHardware,ImportNewSecretRecoveryPhrase,ImportPrivateKey) fromHeaderStackedStandardto the equivalentHeaderCompactStandard+TitleStandardcomposition, preserving back/close/scan actions and moving title/subtitle content intoTitleStandardwithtwClassName="px-4 pt-1 pb-3". Updates theImportPrivateKeysnapshot to match the new header/title render structure.Written by Cursor Bugbot for commit 70ce3a5. This will update automatically on new commits. Configure here.