fix(ramps): wire SSN info tooltip in v2 native flow#26739
Conversation
The SSN info button in V2BasicInfo had no onPress handler, so tapping it did nothing. Register SsnInfoModal in the Ramp modals stack and add the navigation handler so the tooltip opens as expected.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
These are well-scoped changes that only affect the Ramps feature (on-ramp/off-ramp flows). The SsnInfoModal component already exists and is just being wired up to the navigation. The changes include proper unit tests and are low risk since they don't modify core functionality, just add navigation to an existing modal. SmokeRamps is the appropriate tag as it covers fiat on-ramp (buy crypto) and off-ramp (sell crypto) features, which is exactly what this BasicInfo view is part of. Performance Test Selection: |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| 'RampModals', | ||
| expect.objectContaining({ screen: 'RampSsnInfoModal' }), | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Test missing AAA blank-line separation
Low Severity
The new test 'navigates to ssn info modal when ssn info button is pressed' combines Arrange, Act, and Assert on consecutive lines without blank-line separation. The Unit Testing Guidelines (MANDATORY) require every test to follow the AAA pattern with blank lines between each section. The Deposit flow's equivalent test at Deposit/Views/BasicInfo/BasicInfo.test.tsx line 220 correctly separates sections with blank lines, and this test does not match that convention.
Triggered by project rule: Unit Testing Guidelines
The committed fixture schema is out of date. To update, comment: |
Description
The SSN info button (the `ⓘ` icon next to the SSN field) in the v2 Ramps `BasicInfo` screen had no `onPress` handler — tapping it did nothing. The Deposit flow has this working via `createSsnInfoModalNavigationDetails`, but the equivalent was never wired in the v2 flow.
Changes:
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TRAM-3272?atlOrigin=eyJpIjoiYTAxNWU2MWI2NmE1NDRhMTg3YTY5ZjZjNTIxNmIwOTIiLCJwIjoiaiJ9
Manual testing steps
Screenshots/Recordings
Before
Tapping the info icon does nothing.
After
Tapping the info icon opens the SSN info modal.
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI/navigation wiring: adds a new modal route and stack registration plus a small handler and test; main risk is misconfigured route names causing navigation failures.
Overview
Fixes the v2 Ramp
BasicInfoSSN info icon so it actually opens an SSN info bottom sheet modal when pressed.This introduces a new Ramp modal route (
Routes.RAMP.MODALS.SSN_INFO), registersSsnInfoModalin the Ramp modals stack, and adds aBasicInfotest + snapshot update to assert the navigation call.Written by Cursor Bugbot for commit 613520b. This will update automatically on new commits. Configure here.