Skip to content

fix(ramps): plug VerifyIdentity screen into v2 native ramps flow#26738

Merged
AxelGes merged 2 commits into
mainfrom
fix/plug-verify-identity-v2-ramps-native-flow
Mar 2, 2026
Merged

fix(ramps): plug VerifyIdentity screen into v2 native ramps flow#26738
AxelGes merged 2 commits into
mainfrom
fix/plug-verify-identity-v2-ramps-native-flow

Conversation

@AxelGes

@AxelGes AxelGes commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Description

When the user was not authenticated in the v2 Ramps native flow, BuildQuote was navigating directly to EnterEmail, completely skipping the VerifyIdentity screen. The screen existed and was registered in the router but was never wired into the unauthenticated path.

Changes:

  • VerifyIdentity.tsx (NativeFlow): exported V2VerifyIdentityParams and createV2VerifyIdentityNavDetails, added useParams to receive amount/currency/assetId from BuildQuote, and forwarded those params to EnterEmail on submit
  • BuildQuote.tsx: when the user is not authenticated, now navigates to VerifyIdentity instead of EnterEmail
  • Updated tests and snapshots accordingly

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TRAM-3273?atlOrigin=eyJpIjoiMGQ5ZmE1ZmYxMmVlNGQyOWI4ZDBjYThlMDkzNDMzNDIiLCJwIjoiaiJ9

Manual testing steps

Feature: Verify Identity screen in v2 Ramps native flow

  Scenario: user continues as unauthenticated
    Given the user is on the Ramps BuildQuote screen
    And the user is not authenticated (no existing token)

    When user presses the Continue button on a native provider quote
    Then the Verify Identity screen is shown

    When user presses the Continue button on the Verify Identity screen
    Then the Enter Email screen is shown with the correct amount/currency/assetId params

Screenshots/Recordings

Before

BuildQuote -> EnterEmail (VerifyIdentity skipped)

After

BuildQuote -> VerifyIdentity -> EnterEmail -> OtpCode -> routeAfterAuthentication

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: this only adjusts navigation in the unauthenticated v2 native ramps path and threads existing params through; main risk is a miswired route/params causing a broken screen transition.

Overview
Unauthenticated v2 native ramp flow is now wired to show VerifyIdentity first: BuildQuote navigates to Routes.RAMP.VERIFY_IDENTITY (via createV2VerifyIdentityNavDetails) instead of skipping directly to EnterEmail.

VerifyIdentity now accepts amount/currency/assetId via useParams, exports typed nav details, and forwards those params when navigating to EnterEmail. Tests were updated to mock the new nav helper and assert the new navigation/param passing behavior (plus updated snapshots).

Written by Cursor Bugbot for commit a8f9bdb. This will update automatically on new commits. Configure here.

When the user was not authenticated, BuildQuote was navigating directly
to EnterEmail, bypassing the VerifyIdentity screen entirely. Add params
forwarding through VerifyIdentity so amount/currency/assetId are passed
down to EnterEmail, and update tests accordingly.
@AxelGes AxelGes self-assigned this Mar 2, 2026
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Mar 2, 2026
@github-actions github-actions Bot added the size-S label Mar 2, 2026
@AxelGes AxelGes marked this pull request as ready for review March 2, 2026 17:35
@AxelGes AxelGes requested a review from a team as a code owner March 2, 2026 17:35
@AxelGes AxelGes enabled auto-merge March 2, 2026 17:35
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeRamps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are focused on the Ramp (buy/sell crypto) feature's native flow navigation:

  1. BuildQuote.tsx: Changed navigation from createV2EnterEmailNavDetails to createV2VerifyIdentityNavDetails - users now navigate to VerifyIdentity screen before EnterEmail when proceeding with a native provider quote.

  2. VerifyIdentity.tsx: Added navigation parameters support (amount, currency, assetId) and created createV2VerifyIdentityNavDetails navigation helper. The navigateToEnterEmail function now passes these parameters forward.

  3. Test files: Updated to reflect the new navigation flow with proper mocks and assertions.

This is a well-contained change within the Ramp feature that modifies the navigation flow by adding an intermediate step (VerifyIdentity) and passing parameters through the chain. The changes don't affect any core components, controllers, or shared infrastructure. SmokeRamps is the appropriate tag as it covers the on-ramp/off-ramp flows including the native flow screens being modified.

Performance Test Selection:
These changes are purely navigation flow modifications within the Ramp feature - adding an intermediate screen step and passing parameters through navigation. There are no changes to UI rendering, data loading, state management, or any performance-critical paths. The changes don't affect app startup, account lists, swap flows, or any other performance-sensitive areas.

View GitHub Actions results

@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 60
Missing keys 0
Type mismatches 0
Value mismatches 6 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@AxelGes AxelGes added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 77df6cc Mar 2, 2026
91 checks passed
@AxelGes AxelGes deleted the fix/plug-verify-identity-v2-ramps-native-flow branch March 2, 2026 18:30
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 2, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-S team-money-movement issues related to Money Movement features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants