fix(ramps): plug VerifyIdentity screen into v2 native ramps flow#26738
Conversation
When the user was not authenticated, BuildQuote was navigating directly to EnterEmail, bypassing the VerifyIdentity screen entirely. Add params forwarding through VerifyIdentity so amount/currency/assetId are passed down to EnterEmail, and update tests accordingly.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
This is a well-contained change within the Ramp feature that modifies the navigation flow by adding an intermediate step (VerifyIdentity) and passing parameters through the chain. The changes don't affect any core components, controllers, or shared infrastructure. SmokeRamps is the appropriate tag as it covers the on-ramp/off-ramp flows including the native flow screens being modified. Performance Test Selection: |
The committed fixture schema is out of date. To update, comment: |
Description
When the user was not authenticated in the v2 Ramps native flow,
BuildQuotewas navigating directly toEnterEmail, completely skipping theVerifyIdentityscreen. The screen existed and was registered in the router but was never wired into the unauthenticated path.Changes:
VerifyIdentity.tsx(NativeFlow): exportedV2VerifyIdentityParamsandcreateV2VerifyIdentityNavDetails, addeduseParamsto receiveamount/currency/assetIdfromBuildQuote, and forwarded those params toEnterEmailon submitBuildQuote.tsx: when the user is not authenticated, now navigates toVerifyIdentityinstead ofEnterEmailChangelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TRAM-3273?atlOrigin=eyJpIjoiMGQ5ZmE1ZmYxMmVlNGQyOWI4ZDBjYThlMDkzNDMzNDIiLCJwIjoiaiJ9
Manual testing steps
Screenshots/Recordings
Before
BuildQuote -> EnterEmail (VerifyIdentity skipped)
After
BuildQuote -> VerifyIdentity -> EnterEmail -> OtpCode -> routeAfterAuthentication
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: this only adjusts navigation in the unauthenticated v2 native ramps path and threads existing params through; main risk is a miswired route/params causing a broken screen transition.
Overview
Unauthenticated v2 native ramp flow is now wired to show
VerifyIdentityfirst:BuildQuotenavigates toRoutes.RAMP.VERIFY_IDENTITY(viacreateV2VerifyIdentityNavDetails) instead of skipping directly toEnterEmail.VerifyIdentitynow acceptsamount/currency/assetIdviauseParams, exports typed nav details, and forwards those params when navigating toEnterEmail. Tests were updated to mock the new nav helper and assert the new navigation/param passing behavior (plus updated snapshots).Written by Cursor Bugbot for commit a8f9bdb. This will update automatically on new commits. Configure here.