Skip to content

refactor: migrate OnboardingSuccess settings screens to design system with Tailwind CSS#26737

Merged
himanshuchawla009 merged 8 commits into
mainfrom
refactor/onboarding-success-settings-tailwind
Mar 16, 2026
Merged

refactor: migrate OnboardingSuccess settings screens to design system with Tailwind CSS#26737
himanshuchawla009 merged 8 commits into
mainfrom
refactor/onboarding-success-settings-tailwind

Conversation

@tylerc-consensys

@tylerc-consensys tylerc-consensys commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Description

Replace StyleSheet.create() and useStyles() with useTailwind() and Box/twClassName in the OnboardingSuccess settings sub-screens: DefaultSettings, OnboardingAssetsSettings, OnboardingGeneralSettings, and OnboardingSecuritySettings. Delete the now-unused .styles.ts files.

Changelog

CHANGELOG entry: null

Related issues

Refs: TO-558 - Migrate OnboardingSuccess/DefaultSettings to Design System (Box/Text + Tailwind)
Refs: TO-559 - Migrate OnboardingSuccess/OnboardingAssetsSettings to Design System (Box/Text + Tailwind)
Refs: TO-560 - Migrate OnboardingSuccess/OnboardingGeneralSettings to Design System (Box/Text + Tailwind)
Refs: TO-561 - Migrate OnboardingSuccess/OnboardingSecuritySettings to Design System (Box/Text + Tailwind)

Manual testing steps

No functional changes. Visual regression only — verify onboarding settings screens render correctly.

Feature: Onboarding success settings styling

  Scenario: user navigates through default settings
    Given user has completed wallet creation

    When user taps through DefaultSettings, GeneralSettings, AssetsSettings, SecuritySettings
    Then all settings screens render identically to before

Screenshots/Recordings

Before left, After right

Screenshot 2026-03-02 at 11 22 05 AM Screenshot 2026-03-02 at 11 22 14 AM Screenshot 2026-03-02 at 11 22 21 AM Screenshot 2026-03-02 at 11 22 32 AM ## **Pre-merge author checklist**

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Low Risk
Primarily a styling refactor (StyleSheet/useStyles -> Tailwind + design-system Box/Text) with no intended logic changes; main risk is minor visual/layout regressions on the onboarding settings screens.

Overview
Migrates the OnboardingSuccess settings sub-screens to the new design system styling approach. DefaultSettings, OnboardingAssetsSettings, OnboardingGeneralSettings, and OnboardingSecuritySettings now use useTailwind() styles (and Box/design-system Text where applicable) instead of StyleSheet.create() + useStyles().

Removes the now-unused local *.styles.ts files and updates Jest snapshots to reflect the new computed style objects (e.g., flex/padding and text style differences).

Written by Cursor Bugbot for commit c0ea7f9. This will update automatically on new commits. Configure here.

… with Tailwind CSS

Replace StyleSheet.create() and useStyles() with useTailwind() and
Box/twClassName in DefaultSettings, OnboardingAssetsSettings,
OnboardingGeneralSettings, and OnboardingSecuritySettings.
Delete the now-unused .styles.ts files.

Made-with: Cursor
@tylerc-consensys tylerc-consensys added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-onboarding Onboarding team labels Mar 2, 2026
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-S label Mar 2, 2026
@tylerc-consensys tylerc-consensys marked this pull request as ready for review March 2, 2026 09:46
@tylerc-consensys tylerc-consensys requested a review from a team as a code owner March 2, 2026 09:46
Replace deprecated component-library Text in default settings with design-system Text and update snapshot output.

Made-with: Cursor
…uccess-settings-tailwind

# Conflicts:
#	app/components/Views/OnboardingSuccess/DefaultSettings/__snapshots__/index.test.tsx.snap
@tylerc-consensys tylerc-consensys self-assigned this Mar 3, 2026
Regenerate snapshot after fresh yarn install to match CI's resolved
design-token colors (e.g. #131416, #66676a).

Made-with: Cursor
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: @PerformanceOnboarding
  • Risk Level: medium
  • AI Confidence: 70%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are isolated to the OnboardingSuccess views and related settings subcomponents (DefaultSettings, OnboardingAssetsSettings, OnboardingGeneralSettings, OnboardingSecuritySettings). These are part of the post-wallet-creation success flow and affect the UI shown immediately after onboarding completes.

This directly impacts the wallet creation lifecycle and post-onboarding experience, which is covered under SmokeWalletPlatform (wallet lifecycle analytics for new wallet creation and SRP import events, and core wallet platform flows). No evidence of changes to controllers, Engine, network logic, confirmations, trade flows, identity sync, or multi-chain features.

Since onboarding success is part of the core wallet platform experience but not account management internals or SRP export flows, SmokeAccounts and SmokeIdentity are not required. No changes touch Snaps, Trade, Network, Perps, Predictions, Card, Ramps, or MultiChain APIs.

Therefore, run SmokeWalletPlatform to validate that wallet creation and post-onboarding flows remain functional.

Performance Test Selection:
The modified components are rendered at the end of the onboarding flow. UI/layout or additional logic in the OnboardingSuccess screen can affect time-to-interactive and perceived completion time for first-time users. Running @PerformanceOnboarding ensures no regression in wallet creation and first-time user flow performance.

View GitHub Actions results

@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
9 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

sonarqubecloud Bot commented Mar 9, 2026

Copy link
Copy Markdown

@smgv smgv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@himanshuchawla009 himanshuchawla009 added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit 929d7b0 Mar 16, 2026
109 checks passed
@himanshuchawla009 himanshuchawla009 deleted the refactor/onboarding-success-settings-tailwind branch March 16, 2026 08:09
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2026
@metamaskbot metamaskbot added the release-7.71.0 Issue or pull request that will be included in release 7.71.0 label Mar 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.71.0 Issue or pull request that will be included in release 7.71.0 size-S team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants