fix: AccountsApiBalanceFetcher stricter zero out conditions cp-7.67.0#26590
Merged
Prithpal-Sooriya merged 8 commits intomainfrom Feb 26, 2026
Merged
fix: AccountsApiBalanceFetcher stricter zero out conditions cp-7.67.0#26590Prithpal-Sooriya merged 8 commits intomainfrom
Prithpal-Sooriya merged 8 commits intomainfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
salimtb
previously approved these changes
Feb 25, 2026
…atch-asset-zero-out-strictness-check
juanmigdr
previously approved these changes
Feb 26, 2026
Contributor
Author
|
wow weird, got latest and CI is failing bad... Will cancel and retry CI |
tommasini
reviewed
Feb 26, 2026
…atch-asset-zero-out-strictness-check
…d yarn.lock - Updated the version of `@metamask/assets-controllers` from `100.0.1` to `100.0.3` in both `package.json` and `yarn.lock`. - Adjusted the patching references accordingly to ensure consistency across dependencies.
…m:MetaMask/metamask-mobile into fix/patch-asset-zero-out-strictness-check
…e.json and yarn.lock - Removed redundant patch references for `@metamask/assets-controllers` in `package.json`. - Updated `yarn.lock` to reflect the changes in patch references for consistency.
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
bergarces
approved these changes
Feb 26, 2026
MarioAslau
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Patch for the core fix: MetaMask/core#8044 https://consensyssoftware.atlassian.net/browse/ASSETS-2796
Changelog
CHANGELOG entry: fix: AccountsApiBalanceFetcher stricter zero out conditions
Related issues
Fixes: MetaMask/metamask-extension#40324 (this issue also happens on mobile!) #26618
Manual testing steps
Screenshots/Recordings
Before
After
https://www.loom.com/share/d6e472d2ab444205acdad64507f43eed
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches cross-chain balance fetching behavior via a patched dependency; incorrect gating could still cause missing/incorrect displayed balances for some network selections. Dependency patching adds some upgrade/maintenance risk but is scoped to a small conditional change.
Overview
Updates
@metamask/assets-controllersvia a Yarn patch to tighten when missing balances are backfilled as zero inAccountsApiBalanceFetcher.Zero-value native and ERC-20 balances are now only synthesized when the chain was explicitly requested (
chainIds.includes(chainId)) and is supported (supports(chainId)), avoiding unintended zeroing for other chains. The app’s dependency wiring is updated (package.json+yarn.lock) to use the patched@metamask/assets-controllers@100.0.3.Written by Cursor Bugbot for commit c3c5058. This will update automatically on new commits. Configure here.