Skip to content

feat: added 'View all' button in explore search#26569

Merged
juanmigdr merged 25 commits into
mainfrom
feat/added-view-all-in-search
Mar 26, 2026
Merged

feat: added 'View all' button in explore search#26569
juanmigdr merged 25 commits into
mainfrom
feat/added-view-all-in-search

Conversation

@juanmigdr

@juanmigdr juanmigdr commented Feb 25, 2026

Copy link
Copy Markdown
Member

Description

Added 'View All' button for all sections in the Explore page

Changelog

CHANGELOG entry: added 'View All' button for all sections in the Explore page

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2705

Manual testing steps

  • Navigate to the explore page
  • Search for anything like "e"
  • You should see each section showing a "View all" button
  • When clicking on them it should navigate to a screen where it filters by that query
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before & After

Screen.Recording.2026-03-12.at.10.22.00.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds a new navigation route/screen and changes Explore search result rendering and analytics instrumentation, which could affect navigation flows and event reporting. Risk is moderate since it’s UI/metrics focused but touches shared section config and touch/scroll handling.

Overview
Adds a "View all" affordance to Explore search section headers (shown when a section has more than 3 results), limits the inline section preview to 3 items, and navigates to a new ExploreSectionResultsFullView screen that renders the full section results.

Introduces shared Explore search analytics utilities (TapView, TrackedRowItem, useScrollTracking, trackExploreEvent) and a new MetaMetrics event (EXPLORE_SEARCH_INTERACTED) to track taps and first-scroll interactions in both the search results list and the new full-results view.

Updates navigation/types to register the new route (Routes.EXPLORE_SECTION_RESULTS_FULL_VIEW, RootStackParamList) and extends SECTIONS_CONFIG with a required getItemIdentifier for consistent item-level analytics; adds/updates unit tests and snapshots accordingly.

Written by Cursor Bugbot for commit 360771b. This will update automatically on new commits. Configure here.

@github-actions github-actions Bot added size-L and removed size-M labels Mar 12, 2026
@github-actions github-actions Bot added size-M and removed size-L labels Mar 20, 2026
@github-actions github-actions Bot added size-L and removed size-M labels Mar 23, 2026
@juanmigdr juanmigdr marked this pull request as ready for review March 23, 2026 12:39
@juanmigdr juanmigdr requested a review from a team as a code owner March 23, 2026 12:39
@juanmigdr juanmigdr enabled auto-merge March 23, 2026 12:41
@github-actions github-actions Bot added the risk-medium Moderate testing recommended · Possible bug introduction risk label Mar 23, 2026
@github-actions github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 23, 2026
@juanmigdr juanmigdr added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Mar 23, 2026
@juanmigdr juanmigdr removed the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Mar 26, 2026
@github-actions github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 26, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@MetaMask MetaMask deleted a comment from cursor Bot Mar 26, 2026
@github-actions github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 26, 2026
sahar-fehri
sahar-fehri previously approved these changes Mar 26, 2026
Comment thread app/components/Views/TrendingView/utils/exploreSearch.tsx Outdated
@github-actions github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokePerps, SmokePredictions
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR introduces a new "View All" / ExploreSectionResultsFullView screen within the Trending/Explore search feature, along with analytics tracking utilities and navigation registration.

Key changes:

  1. New ExploreSectionResultsFullView screen: A new navigation screen registered in MainNavigator.js that shows full results for a search section. This is additive and low-risk for existing navigation.
  2. sections.config.tsx: Added getItemIdentifier to SectionConfig interface (now required) with implementations for all sections (Tokens, Perps, RWA, Predictions, Sites). This is a structural change to the config used by all Trending sections.
  3. ExploreSearchResults.tsx: Enhanced with "View All" button per section, scroll/tap analytics tracking, and navigation to the new full view. This modifies existing search result rendering.
  4. New exploreSearch.tsx utility: Analytics tracking utilities (TapView, trackExploreEvent, useScrollTracking, TrackedRowItem) used by both ExploreSearchResults and ExploreSectionResultsFullView.
  5. Analytics event: New EXPLORE_SEARCH_INTERACTED event added additively.
  6. Navigation types/routes: Additive changes for the new screen.

Tag selection rationale:

  • SmokeWalletPlatform: Directly covers Trending discovery tab, search functionality, and browsing content feeds (Predictions, Tokens, Perps, Sites sections). The core changes are within this feature area.
  • SmokePerps: The sections.config.tsx changes affect the Perps section's getItemIdentifier, and Perps is a section inside Trending. Per tag description, changes to Perps views affect Trending.
  • SmokePredictions: The sections.config.tsx changes affect the Predictions section's getItemIdentifier, and Predictions is a section inside Trending. Per tag description, changes to Predictions views affect Trending.

Dependent tags per descriptions:

  • SmokePerps → SmokeWalletPlatform (already included), SmokeConfirmations (for Add Funds deposits) - not needed here as no confirmation flows are changed
  • SmokePredictions → SmokeWalletPlatform (already included), SmokeConfirmations (for on-chain transactions) - not needed here as no confirmation flows are changed

The changes do not touch: confirmations, accounts, identity, network management, swaps/bridge, ramps, card, snaps, or multi-chain API. The MainNavigator.js change is additive (new screen registration) and doesn't modify existing screen routing.

Performance Test Selection:
The changes are within the Trending/Explore search feature, adding a new 'View All' screen with FlashList rendering. While FlashList is performance-sensitive, these are new screens within an existing feature area and don't affect core infrastructure like app startup, login, account loading, or swap flows. No performance test tags directly cover Trending/Explore search result rendering. The changes are additive and unlikely to regress existing performance benchmarks.

View GitHub Actions results

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

Copy link
Copy Markdown

@juanmigdr juanmigdr added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit 241087f Mar 26, 2026
93 of 94 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 26, 2026
@juanmigdr juanmigdr deleted the feat/added-view-all-in-search branch March 26, 2026 17:00
@metamaskbot metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.72.0 Issue or pull request that will be included in release 7.72.0 risk-medium Moderate testing recommended · Possible bug introduction risk size-XL team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants