Skip to content

chore(predict): cp-7.66.0 remove code related to super bowl banner on carousel#26363

Merged
caieu merged 1 commit into
mainfrom
predict/remove-superbowl-banner
Feb 20, 2026
Merged

chore(predict): cp-7.66.0 remove code related to super bowl banner on carousel#26363
caieu merged 1 commit into
mainfrom
predict/remove-superbowl-banner

Conversation

@caieu

@caieu caieu commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Description

The Carousel previously had special handling for the Predict Superbowl banner: it could replace the entire carousel with a single PredictMarketSportCardWrapper when a Superbowl slide with a marketId was present, and hid that slide from the normal carousel. This change removes that integration.

What changed:

  • Carousel (index.tsx): Removed Predict/Superbowl imports, the predictSuperbowlSlide and predictSuperbowlMarketId memos, the early return that rendered PredictMarketSportCardWrapper, the filter that excluded PREDICT_SUPERBOWL_VARIABLE_NAME from visible slides, and the handleSportCardDismiss / handlePredictSuperbowlLoad callbacks (including "Banner Display" tracking for the Superbowl card).
  • Tests (index.test.tsx): Removed the PredictMarketSportCardWrapper mock, the PREDICT_SUPERBOWL_VARIABLE_NAME import, and the entire "Carousel Predict Superbowl Integration" describe block and its five tests (render with/without marketId, props, tracking).

The Carousel no longer has any Superbowl-specific behavior; any such slides from Contentful would now be treated as normal carousel slides.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Removes a one-off UI code path and its tests; behavior is simplified with minimal impact outside the Predict Superbowl banner scenario.

Overview
Removes the Carousel’s special-case integration for the Predict Super Bowl banner. The carousel no longer suppresses PREDICT_SUPERBOWL_VARIABLE_NAME slides, no longer renders PredictMarketSportCardWrapper as a full replacement view based on marketId, and drops the associated dismiss/load handlers and Superbowl-specific metrics.

Updates index.test.tsx by deleting the Predict sport card mock and the entire Predict Superbowl integration test suite, leaving only the generic carousel behavior tests.

Written by Cursor Bugbot for commit d585da9. This will update automatically on new commits. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-predict Predict team label Feb 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes remove the Predict Superbowl integration from the Carousel component. This is a feature removal that:

  1. Removes imports: PredictMarketSportCardWrapper, PredictEventValues, PREDICT_SUPERBOWL_VARIABLE_NAME, and PredictCarouselMetadata
  2. Removes logic: predictSuperbowlSlide and predictSuperbowlMarketId memoized values, the filter excluding predict superbowl slides, handleSportCardDismiss and handlePredictSuperbowlLoad callbacks, and the conditional rendering of PredictMarketSportCardWrapper
  3. Removes tests: All unit tests related to Predict Superbowl integration in the Carousel

The Carousel component is used on the wallet home screen (imported in app/components/Views/Wallet/index.tsx). The change is well-scoped and only affects the Carousel component's handling of Predict Superbowl slides.

SmokeWalletPlatform is selected because:

  • The Carousel is on the wallet home screen
  • The tag covers "core wallet platform features" including the wallet view
  • It will verify the wallet home screen still renders correctly after this change

SmokePredictions is NOT selected because:

  • The Predict feature itself is not affected - PredictMarketSportCard is still used in PredictMarket.tsx
  • This only removes the Carousel integration, not the Predict functionality
  • There are no E2E tests for the Predict Superbowl carousel integration

This is a low-risk change because it's removing code (reducing complexity) rather than adding new functionality.

Performance Test Selection:
No performance tests needed. This change removes code from the Carousel component (Predict Superbowl integration), which simplifies the component and should not negatively impact performance. The change is a feature removal, not an addition, and no performance-critical paths are affected.

View GitHub Actions results

@caieu caieu marked this pull request as ready for review February 20, 2026 17:37
@caieu caieu enabled auto-merge February 20, 2026 17:37

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment thread app/components/UI/Carousel/index.tsx
@sonarqubecloud

Copy link
Copy Markdown

@caieu caieu added this pull request to the merge queue Feb 20, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 20, 2026
@caieu caieu added this pull request to the merge queue Feb 20, 2026
Merged via the queue into main with commit 6eb88ac Feb 20, 2026
114 of 116 checks passed
@caieu caieu deleted the predict/remove-superbowl-banner branch February 20, 2026 19:23
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2026
@metamaskbot metamaskbot added the release-7.68.0 Issue or pull request that will be included in release 7.68.0 label Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.68.0 Issue or pull request that will be included in release 7.68.0 size-M team-predict Predict team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants