Skip to content

chore: add support for x only sources#26335

Merged
zone-live merged 3 commits into
mainfrom
TSA-175-mrkt-insights-add-support-for-x-only-trend-sources
Feb 20, 2026
Merged

chore: add support for x only sources#26335
zone-live merged 3 commits into
mainfrom
TSA-175-mrkt-insights-add-support-for-x-only-trend-sources

Conversation

@zone-live

@zone-live zone-live commented Feb 20, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Market Insights "What’s driving the price?" previously showed source icons and the sources sheet only for trends with articles. This PR adds support for tweet-only trends as well.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only changes to Market Insights source rendering/selection with added test coverage; no auth, payments, or persistence logic touched.

Overview
Enables Market Insights trends to surface tweet-only sources in both the trend list and the “sources” bottom sheet, instead of only supporting article-backed trends.

Trend selection now opens the sources sheet when a trend has tweets (even if it has no articles), the sheet renders tweet entries with an X icon and opens tweet URLs, and trend items include x.com in their displayed source icons. Adds/updates unit tests to cover tweet-only trends and tweet source passing/URL opening, plus a small selector memoization simplification in MainNavigator.

Written by Cursor Bugbot for commit fe5970d. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-social-ai Social & AI team label Feb 20, 2026
@github-actions github-actions Bot added size-M and removed size-S labels Feb 20, 2026
@github-actions

github-actions Bot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are isolated to the MarketInsights feature, which is:

  1. Feature-flagged: Controlled by selectMarketInsightsEnabled feature flag
  2. No existing E2E tests: Grep search confirmed no .spec.* files exist for MarketInsights
  3. Additive changes only: Adding tweet support to an existing feature (articles + tweets in trend sources)
  4. UI-only modifications:
    • MarketInsightsView: Now checks for tweets in addition to articles before opening trend sources sheet
    • MarketInsightsTrendItem: Shows X icon when tweets are present
    • MarketInsightsTrendSourcesBottomSheet: Renders tweet sources alongside articles
  5. MainNavigator change is trivial: Removed unnecessary useMemo wrapper - no functional change

The changes don't affect:

  • Core wallet functionality or navigation
  • Any existing E2E test flows (SmokeWalletPlatform's Trending tests are separate from MarketInsights)
  • Critical paths like confirmations, accounts, or network management

Unit tests were added to cover the new tweet functionality. Since there are no E2E tests for this feature and the changes are low-risk UI additions behind a feature flag, no E2E tags are needed.

Performance Test Selection:
The changes are purely UI additions to the MarketInsights feature (adding tweet rendering support). No performance-critical paths are affected: no changes to list rendering performance, data loading, state management, app startup, or critical user flows. The modifications are additive UI elements (rendering tweets in a bottom sheet) that don't impact app responsiveness or render times in any measurable way.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Feb 20, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zone-live zone-live added this pull request to the merge queue Feb 20, 2026
cursor[bot]
cursor Bot reviewed Feb 20, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment thread app/components/UI/MarketInsights/components/MarketInsightsTrendSourcesBottomSheet.test.tsx
Merged via the queue into main with commit 147e394 Feb 20, 2026
61 checks passed
@zone-live zone-live deleted the TSA-175-mrkt-insights-add-support-for-x-only-trend-sources branch February 20, 2026 15:01
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2026
@metamaskbot metamaskbot added the release-7.68.0 Issue or pull request that will be included in release 7.68.0 label Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@xavier-brochard xavier-brochard xavier-brochard approved these changes

Assignees

No one assigned

Labels

release-7.68.0 Issue or pull request that will be included in release 7.68.0 size-M team-social-ai Social & AI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zone-live @xavier-brochard @metamaskbot