Skip to content

feat: remove quote details tooltip cta and fix paddings#26156

Merged
GeorgeGkas merged 3 commits into
mainfrom
swaps-4129
Feb 20, 2026
Merged

feat: remove quote details tooltip cta and fix paddings#26156
GeorgeGkas merged 3 commits into
mainfrom
swaps-4129

Conversation

@GeorgeGkas

@GeorgeGkas GeorgeGkas commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Make TooltipModal CTA optional to prevent rendering the CTA of the tooltip on top of the swaps CTA causing misclicks.

Changelog

CHANGELOG entry: remove quote details tooltip cta and fix paddings

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-4129

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

εικόνα

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small UI param removal limited to tooltip modal configuration and test updates; low chance of behavioral impact beyond tooltip spacing.

Overview
Bridge QuoteDetailsCard no longer passes a hardcoded bottomPadding to the tooltip modal for quote rate, network fee, slippage, minimum received, price impact, and rewards tooltips, removing the now-unused TOOLTIP_BOTTOM_PADDING constant.

Associated navigation assertions in QuoteDetailsCard.test.tsx were updated to expect tooltip modal params without bottomPadding.

Written by Cursor Bugbot for commit 00ad73f. This will update automatically on new commits. Configure here.

@GeorgeGkas GeorgeGkas requested review from a team as code owners February 17, 2026 13:34
@github-actions

github-actions Bot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Feb 17, 2026
infiniteflower
infiniteflower previously approved these changes Feb 17, 2026
View reviewed changes
@GeorgeGkas GeorgeGkas requested review from infiniteflower and removed request for a team February 20, 2026 10:29
@github-actions

github-actions Bot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeTrade, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes remove the bottomPadding property from tooltip configurations in the Bridge QuoteDetailsCard component. This is a purely cosmetic/UI change that removes extra bottom padding from tooltip modals that was previously used to prevent the close button from overlapping with the Swap button.

The changes affect:

  1. QuoteDetailsCard.tsx - Removes TOOLTIP_BOTTOM_PADDING constant and its usage in 9 tooltip configurations
  2. QuoteDetailsCard.test.tsx - Updates unit tests to reflect the removal of bottomPadding from expected navigation parameters

The QuoteDetailsCard component is used in the BridgeView, which is part of the Bridge/Swap trading flow. According to the tag descriptions, SmokeTrade covers "cross-chain bridging between networks" and when selecting SmokeTrade for swap or bridge flows, SmokeConfirmations should also be selected since "transaction confirmations are part of the flow".

This is a low-risk change because:

  • It's a UI styling change only (removing padding)
  • No functional/business logic changes
  • Unit tests are properly updated
  • The core Bridge functionality remains unchanged

Performance Test Selection:
This change only removes a padding value from tooltip modal configurations. It doesn't affect UI rendering performance, data loading, state management, or any critical user flows. The change is purely cosmetic and has no performance implications.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Feb 20, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GeorgeGkas GeorgeGkas added this pull request to the merge queue Feb 20, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 20, 2026
@GeorgeGkas GeorgeGkas added this pull request to the merge queue Feb 20, 2026
Merged via the queue into main with commit ce498e9 Feb 20, 2026
98 checks passed
@GeorgeGkas GeorgeGkas deleted the swaps-4129 branch February 20, 2026 11:40
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2026
@metamaskbot metamaskbot added the release-7.68.0 Issue or pull request that will be included in release 7.68.0 label Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bfullam bfullam bfullam approved these changes

@infiniteflower infiniteflower Awaiting requested review from infiniteflower

Assignees

No one assigned

Labels

release-7.68.0 Issue or pull request that will be included in release 7.68.0 size-S team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GeorgeGkas @bfullam @infiniteflower @metamaskbot