Skip to content

test: Stabilize BTC insufficient funds smoke assertion#26066

Merged
javiergarciavera merged 2 commits intomainfrom
cursor/btc-send-test-flakiness-c63d
Feb 13, 2026
Merged

test: Stabilize BTC insufficient funds smoke assertion#26066
javiergarciavera merged 2 commits intomainfrom
cursor/btc-send-test-flakiness-c63d

Conversation

@javiergarciavera
Copy link
Copy Markdown
Contributor

@javiergarciavera javiergarciavera commented Feb 13, 2026 •
edited by cursor bot
Loading

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test-only change that tightens a UI assertion; low risk aside from potential for increased test flakiness if the expected text/id changes.

Overview
Updates the RedesignedSendView page object’s checkInsufficientFundsError assertion to verify the error message text via Assertions.expectElementToHaveText (instead of only checking visibility), improving stability/accuracy of the insufficient-funds smoke check.

Written by Cursor Bugbot for commit 9f85db9. This will update automatically on new commits. Configure here.

@cursoragent @javiergarciavera
Stabilize BTC insufficient funds smoke assertion
fdf3422 
Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
@javiergarciavera javiergarciavera requested a review from a team as a code owner February 13, 2026 12:46
@metamaskbot metamaskbot added the team-qa QA team label Feb 13, 2026
@javiergarciavera javiergarciavera added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 13, 2026
cursor[bot]
cursor bot reviewed Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@cursoragent @javiergarciavera
Fix send page object assertion typing for CI
9f85db9 
Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
@github-actions github-actions bot added size-XS and removed size-S labels Feb 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 13, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change modifies the checkInsufficientFundsError() method in the RedesignedSendView.ts page object file, changing the assertion from expectElementToBeVisible to expectElementToHaveText. This is a test infrastructure change that makes the assertion more specific by checking both visibility and text content.

The method is used in two test files:

  1. send-btc-token.spec.ts - Tagged with SmokeConfirmations (active test)
  2. send-tron-token.spec.ts - Tagged with SmokeConfirmations (skipped test)

Both tests are in the tests/smoke/confirmations/send/ directory and use the SmokeConfirmations tag. Running SmokeConfirmations will validate that the modified assertion works correctly for the send flow tests.

The change is low risk because:

  • It's a test infrastructure change, not app code
  • The change makes the assertion more specific (checking text content in addition to visibility)
  • Only affects the insufficient funds error check in send flows
  • The Tron test is currently skipped, so only the BTC test will actually run

Performance Test Selection:
This change is purely a test infrastructure modification to a page object assertion method. It does not affect any app code, UI rendering, data loading, or any user-facing functionality. No performance impact is expected from this change.

View GitHub Actions results

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.18%. Comparing base (ccaa928) to head (9f85db9).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #26066      +/-   ##
==========================================
+ Coverage   81.13%   81.18%   +0.05%     
==========================================
  Files        4387     4392       +5     
  Lines      113355   113429      +74     
  Branches    24339    24348       +9     
==========================================
+ Hits        91966    92089     +123     
+ Misses      15009    14976      -33     
+ Partials     6380     6364      -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 13, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2026
@javiergarciavera javiergarciavera added this pull request to the merge queue Feb 13, 2026
Merged via the queue into main with commit bf8cf2d Feb 13, 2026
243 of 245 checks passed
@javiergarciavera javiergarciavera deleted the cursor/btc-send-test-flakiness-c63d branch February 13, 2026 14:24
@metamaskbot metamaskbot added the release-7.67.0 Issue or pull request that will be included in release 7.67.0 label Feb 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@christopherferreira9 christopherferreira9 christopherferreira9 approved these changes

@hjetpoluru hjetpoluru hjetpoluru approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.67.0 Issue or pull request that will be included in release 7.67.0 size-XS team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@javiergarciavera @codecov-commenter @christopherferreira9 @hjetpoluru @metamaskbot @cursoragent