Skip to content

fix: whitelist add buy & sell deeplinks#26038

Merged
cortisiko merged 2 commits intomainfrom
fix/whitelist-ramps-deep-links
Feb 12, 2026
Merged

fix: whitelist add buy & sell deeplinks#26038
cortisiko merged 2 commits intomainfrom
fix/whitelist-ramps-deep-links

Conversation

@cortisiko
Copy link
Copy Markdown
Member

@cortisiko cortisiko commented Feb 12, 2026 •
edited by cursor bot
Loading

Description

The purpose of this PR is to fix universal link handling for buy/sell deeplinks by removing the unnecessary "Proceed with
caution" interstitial modal. The issue was that Buy, sell, and swap deeplinks (e.g., metamask://buy?chainId=1&amount=275) were triggering an interstitial modal requiring user confirmation. What I did here was to add BUY, BUY_CRYPTO, SELL, SELL_CRYPTO, actions to WHITELISTED_ACTIONS in handleUniversalLink.ts.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small, localized change to deep link gating logic; risk is limited to potentially bypassing the interstitial for buy/sell links if the whitelist is too permissive.

Overview
Buy/sell universal links now skip the “Proceed with caution” interstitial by adding BUY, BUY_CRYPTO, SELL, and SELL_CRYPTO to WHITELISTED_ACTIONS in handleUniversalLink.ts.

This changes universal link handling so these ramp-related deeplinks proceed directly while still being treated as supported actions for downstream routing/analytics.

Written by Cursor Bugbot for commit 9e1fc60. This will update automatically on new commits. Configure here.

@cortisiko cortisiko requested a review from a team as a code owner February 12, 2026 21:07
@metamaskbot metamaskbot added the team-qa QA team label Feb 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 12, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeRamps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change adds BUY, BUY_CRYPTO, SELL, and SELL_CRYPTO actions to the WHITELISTED_ACTIONS array in handleUniversalLink.ts. This means these deep link actions will now skip the interstitial confirmation modal and proceed directly to the buy/sell flows.

This is a targeted change that:

  1. Only affects deep link handling for buy/sell crypto flows
  2. Adds actions to an existing whitelist (not modifying core logic)
  3. The buy/sell functionality already exists and works - this just removes an extra confirmation step

The SmokeRamps tag is appropriate because it covers:

  • Deep link navigation into buy flows from external sources
  • On-ramp (buy crypto) and off-ramp (sell crypto) features
  • The existing test file tests/smoke/ramps/deeplink-to-buy-flow.failing.ts specifically tests buy crypto deep links

No other tags are needed because:

  • The change doesn't affect confirmations (SmokeConfirmations) - it's about skipping a modal, not transaction confirmations
  • The change doesn't affect wallet platform features (SmokeWalletPlatform) beyond the ramps entry point
  • No other features are impacted by this whitelist addition

Performance Test Selection:
This change only affects deep link modal display logic - specifically adding buy/sell actions to a whitelist that skips the interstitial confirmation modal. It does not impact: UI rendering performance, data loading, state management, app startup, or any critical performance paths. The change is purely about skipping a modal dialog for certain deep link actions, which has no measurable performance impact.

View GitHub Actions results

@cortisiko cortisiko added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 12, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 12, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cortisiko cortisiko enabled auto-merge February 12, 2026 21:35
MarioAslau
MarioAslau approved these changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added this pull request to the merge queue Feb 12, 2026
Merged via the queue into main with commit ac5fe0c Feb 12, 2026
102 of 106 checks passed
@cortisiko cortisiko deleted the fix/whitelist-ramps-deep-links branch February 12, 2026 22:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2026
@metamaskbot metamaskbot added the release-7.67.0 Issue or pull request that will be included in release 7.67.0 label Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgeweiler georgeweiler georgeweiler approved these changes

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.67.0 Issue or pull request that will be included in release 7.67.0 size-XS team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cortisiko @georgeweiler @MarioAslau @metamaskbot