Skip to content

chore: consolidate navigation style - web3auth team#25882

Merged
asalsys merged 6 commits into
mainfrom
chore/consolidate-navigation-style-web3auth
Feb 18, 2026
Merged

chore: consolidate navigation style - web3auth team#25882
asalsys merged 6 commits into
mainfrom
chore/consolidate-navigation-style-web3auth

Conversation

@asalsys

@asalsys asalsys commented Feb 10, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

This PR consolidates navigation styles across the codebase by replacing inline navigationOptions style definitions with the shared getNavigationOptionsTitle utility function.

Reason for change:

  • Preparing the codebase for the upgrade to React Navigation v6
  • Navigation header styles were defined inconsistently across components using the legacy navigationOptions pattern
  • Centralizing navigation options will make the migration to React Navigation v6's new API smoother and reduce the scope of changes required during the upgrade

Solution:

  • Replaced inline style definitions with the centralized getNavigationOptionsTitle function from app/components/UI/Navbar
  • This ensures consistent navigation header styling across the app and simplifies the upcoming React Navigation v6 migration

Changelog

CHANGELOG entry: null

Related issues

Fixes: #23765 Part of React Navigation v6 upgrade preparation (split from original PR for easier code review by team)

Manual testing steps

Feature: Navigation header consistency

Scenario: User navigates to screens affected by this PR
Given the app is running

When user navigates to any screen modified in this PR
Then the navigation header should display correctly with proper title styling
And the back button should function as expected

Screenshots/Recordings

Before

N/A - No visual changes

After

N/A - No visual changes

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Small but user-facing change to navigation routing; risk is limited to potentially breaking the onboarding success-to-default-settings transition if route nesting assumptions differ.

Overview
Updates the Onboarding Success "Manage default settings" action to navigate directly to Routes.ONBOARDING.DEFAULT_SETTINGS instead of navigating via the nested Routes.ONBOARDING.SUCCESS_FLOW stack.

Adjusts the corresponding test expectation to match the new navigation call signature.

Written by Cursor Bugbot for commit 7382491. This will update automatically on new commits. Configure here.

@asalsys asalsys self-assigned this Feb 10, 2026
@asalsys asalsys added the team-mobile-platform Mobile Platform team label Feb 10, 2026
@github-actions

github-actions Bot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud

sonarqubecloud Bot commented Feb 10, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to a simple navigation pattern refactoring in the OnboardingSuccess component. The change modifies how the "Manage Default Settings" button navigates - from a nested navigator pattern to direct navigation. This is a minor code simplification that:

  1. Only affects the OnboardingSuccess screen's navigation to DefaultSettings
  2. Has corresponding unit test updates that verify the new navigation pattern
  3. Does not affect any core wallet functionality, transactions, or user flows
  4. No E2E tests in the tests directory directly test this specific navigation flow (searched for OnboardingSuccess test IDs and DEFAULT_SETTINGS references)

The change is isolated to the onboarding flow and is a straightforward navigation fix. The unit tests have been properly updated to reflect the change, providing adequate coverage for this modification. No E2E tags are needed as this is a low-risk, well-tested navigation refactoring.

Performance Test Selection:
This change is a simple navigation pattern refactoring that does not affect UI rendering performance, data loading, state management, or any critical user flows. The change only modifies how navigation is called (from nested to direct navigation) without any impact on app performance metrics like startup time, render times, or data loading.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Feb 12, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@asalsys asalsys marked this pull request as ready for review February 16, 2026 17:07
@asalsys asalsys requested a review from a team as a code owner February 16, 2026 17:07
@asalsys asalsys enabled auto-merge February 16, 2026 17:08
ieow
ieow approved these changes Feb 18, 2026
View reviewed changes

@ieow ieow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asalsys asalsys added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 029c4c2 Feb 18, 2026
66 checks passed
@asalsys asalsys deleted the chore/consolidate-navigation-style-web3auth branch February 18, 2026 06:55
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 18, 2026
@metamaskbot metamaskbot added the release-7.67.0 Issue or pull request that will be included in release 7.67.0 label Feb 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ieow ieow ieow approved these changes

Assignees

@asalsys asalsys

Labels

release-7.67.0 Issue or pull request that will be included in release 7.67.0 size-XS team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[NAV UPGRADE - 4] Consolidate navigation API call style

3 participants

@asalsys @ieow @metamaskbot