chore: bump assets controllers to 99.3.0 to fix stock badges on homepage by oscarwroche · Pull Request #25775 · MetaMask/metamask-mobile

oscarwroche · 2026-02-06T14:00:51Z

Description

Bumping the version of assets-controllers to fix a cache issue that prevents stock badges from being displayed for RWA tokens

Changelog

CHANGELOG entry: Fixed cache issue for RWA token stock badges not appearing on home page

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Dependency upgrade in the assets/controller layer could change token/asset caching and badge display behavior beyond the intended fix, though the PR itself is primarily version/lockfile churn.

Overview
Updates @metamask/assets-controllers from a locally patched 99.2.0 to ^99.3.0 (lockfile resolves to 99.3.1), removing the patch override.

Adds a changelog entry noting a fix for cached RWA token stock badges not appearing on the home/trending UI.

^{Written by Cursor Bugbot for commit acfbc22. This will update automatically on new commits. Configure here.}

github-actions · 2026-02-06T14:01:02Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…trollers-99.3.0

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

cursor · 2026-02-10T15:48:41Z

package.json

    "@metamask/app-metadata-controller": "^2.0.0",
    "@metamask/approval-controller": "^8.0.0",
-    "@metamask/assets-controllers": "patch:@metamask/assets-controllers@npm%3A99.2.0#~/.yarn/patches/@metamask-assets-controllers-npm-99.2.0-bf6ecbcde9.patch",
+    "@metamask/assets-controllers": "^99.3.0",


Resolutions still force old patched 99.2.0 for transitive deps

High Severity

The direct dependency @metamask/assets-controllers was bumped to ^99.3.0, but the resolutions section (lines 189–190) still redirects @metamask/assets-controllers@npm:^99.2.0 and @metamask/assets-controllers@npm:^97.0.0 to the old patched 99.2.0. This means transitive dependencies that request those ranges will still receive the old version without the cache fix. The project ends up with two installed versions of assets-controllers (99.3.1 and patched 99.2.0), potentially undermining the very fix this PR intends to ship.

…trollers-99.3.0

github-actions · 2026-02-11T15:49:18Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
Risk Level: high
AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/assets-controllers. Running all tests.

Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/assets-controllers. Running all tests.

View GitHub Actions results

sonarqubecloud · 2026-02-11T16:12:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Akaryatrh · 2026-02-12T08:27:51Z

Closed in favor of #25796

chore: bump assets controllers to 99.3.0 to fix stock badges on homepage

74437de

metamaskbot added the team-be-trade BE Trade team label Feb 6, 2026

github-actions bot added the size-XS label Feb 6, 2026

oscarwroche added 4 commits February 6, 2026 15:02

chore: update changelog

2b8981d

chore: deduplicate dependencies

0508425

Merge branch 'main' into chore/bump-assets-controllers-99.3.0

9ed6653

Merge branch 'main' into chore/bump-assets-controllers-99.3.0

385bf9f

Akaryatrh previously approved these changes Feb 6, 2026

View reviewed changes

Akaryatrh enabled auto-merge February 6, 2026 16:53

Akaryatrh and others added 2 commits February 6, 2026 17:58

Merge branch 'main' into chore/bump-assets-controllers-99.3.0

b18c0ac

Merge branch 'main' into chore/bump-assets-controllers-99.3.0

6ef8422

asalsys previously approved these changes Feb 6, 2026

View reviewed changes

Merge branch 'main' into chore/bump-assets-controllers-99.3.0

3404731

oscarwroche disabled auto-merge February 7, 2026 08:48

Merge branch 'main' into chore/bump-assets-controllers-99.3.0

6a94b10

Akaryatrh enabled auto-merge February 9, 2026 08:56

Akaryatrh added 2 commits February 9, 2026 12:55

Merge remote-tracking branch 'origin/main' into chore/bump-assets-con…

edeadd6

…trollers-99.3.0

feat: update lockfile after merging main in

3a78b3d

Akaryatrh dismissed stale reviews from asalsys and themself via 3a78b3d February 9, 2026 11:57

Akaryatrh previously approved these changes Feb 9, 2026

View reviewed changes

Akaryatrh added 2 commits February 10, 2026 16:42

Merge remote-tracking branch 'origin/main' into chore/bump-assets-con…

4b7e979

…trollers-99.3.0

feat: update lockfile after merge from main

c9ce24f

Akaryatrh dismissed their stale review via c9ce24f February 10, 2026 15:45

Akaryatrh previously approved these changes Feb 10, 2026

View reviewed changes

cursor bot reviewed Feb 10, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into chore/bump-assets-con…

3fd89c5

…trollers-99.3.0

Akaryatrh dismissed their stale review via 3fd89c5 February 11, 2026 08:13

Merge branch 'main' into chore/bump-assets-controllers-99.3.0

c7f0d59

Akaryatrh added 2 commits February 11, 2026 11:51

Merge branch 'main' into chore/bump-assets-controllers-99.3.0

6cb966d

Merge branch 'main' into chore/bump-assets-controllers-99.3.0

acfbc22

Akaryatrh approved these changes Feb 11, 2026

View reviewed changes

Akaryatrh mentioned this pull request Feb 11, 2026

chore: bump @metamask/assets-controllers from ^99.0.0 to ^99.3.1 #25796

Merged

7 tasks

Akaryatrh closed this Feb 12, 2026

auto-merge was automatically disabled February 12, 2026 08:27
Pull request was closed

github-actions bot locked and limited conversation to collaborators Feb 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: bump assets controllers to 99.3.0 to fix stock badges on homepage#25775

chore: bump assets controllers to 99.3.0 to fix stock badges on homepage#25775
oscarwroche wants to merge 17 commits intomainfrom
chore/bump-assets-controllers-99.3.0

oscarwroche commented Feb 6, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Feb 10, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

sonarqubecloud bot commented Feb 11, 2026

Uh oh!

Akaryatrh commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

oscarwroche commented Feb 6, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 10, 2026

Choose a reason for hiding this comment

Resolutions still force old patched 99.2.0 for transitive deps

Uh oh!

github-actions bot commented Feb 11, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud bot commented Feb 11, 2026

Quality Gate passed

Uh oh!

Akaryatrh commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oscarwroche commented Feb 6, 2026 •

edited by cursor bot

Loading