Skip to content

fix: initial predict deposit using polygon usdce#25774

Merged
matthewwalsh0 merged 1 commit intomainfrom
fix/predict-disable-upgrade
Feb 6, 2026
Merged

fix: initial predict deposit using polygon usdce#25774
matthewwalsh0 merged 1 commit intomainfrom
fix/predict-disable-upgrade

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented Feb 6, 2026

Description

Remove disableUpgrade optimisation for Predict deposits to ensure non-Relay transactions using Polygon USDCe can still upgrade the EOA.

Intentionally not applied per transaction data to reduce complexity and improve stability.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #6820

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches transaction submission options for deposits; behavior changes could affect batching/upgrade flow on Polygon and should be validated against real deposit scenarios.

Overview
Predict deposits no longer pass disableUpgrade: true to addTransactionBatch in PredictController.depositWithConfirmation, allowing the underlying transaction flow to perform an account upgrade when required (e.g., non-relay Polygon USDCe deposits).

Updates the deposit unit test to match the new addTransactionBatch call signature (removing the disableUpgrade expectation).

Written by Cursor Bugbot for commit 19019f2. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions, SmokeConfirmations, SmokeWalletPlatform
  • Selected Performance tags: @PerformancePredict
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes remove the disableUpgrade: true flag from the addTransactionBatch call in PredictController.ts. This is a focused change that affects how prediction market transactions are processed - specifically enabling transaction upgrades that were previously disabled.

The PredictController is a Phase 6 (business logic) controller that handles Polymarket prediction market integration. The change is isolated to this feature domain.

Tag selection rationale:

  1. SmokePredictions - Directly tests the Polymarket prediction market integration including opening positions, cashing out, and claiming winnings - all of which involve transactions that would be affected by this change.
  2. SmokeConfirmations - Per tag description guidance, when selecting SmokePredictions, also select SmokeConfirmations since opening/closing positions are on-chain transactions that go through the confirmation flow.
  3. SmokeWalletPlatform - Per tag description guidance, Predictions is a section inside the Trending tab, so changes to Predictions views affect this tag.

The test file change (PredictController.test.ts) simply updates the test expectations to match the code change, removing the same flag from the expected call parameters.

Performance Test Selection:
The change affects transaction processing in the PredictController, specifically how transaction batches are submitted for prediction market operations. The @PerformancePredict tag covers prediction market flows including deposit flows and balance display, which could be impacted by changes to transaction upgrade behavior. While the change is small (removing a flag), it could affect transaction processing timing and performance characteristics.

View GitHub Actions results

@matthewwalsh0 matthewwalsh0 changed the title fix(predict): remove disableUpgrade from deposit addTransactionBatch call fix: initial predict deposit using polygon usdce Feb 6, 2026
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review February 6, 2026 13:55
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner February 6, 2026 13:55
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

@caieu caieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit c60765c Feb 6, 2026
135 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/predict-disable-upgrade branch February 6, 2026 14:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
@metamaskbot metamaskbot added the release-7.66.0 Issue or pull request that will be included in release 7.66.0 label Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.66.0 Issue or pull request that will be included in release 7.66.0 size-XS team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants