Skip to content

fix: new button layout issues#25771

Merged
bergarces merged 10 commits intomainfrom
fix-button-layout-bugs
Feb 6, 2026
Merged

fix: new button layout issues#25771
bergarces merged 10 commits intomainfrom
fix-button-layout-bugs

Conversation

@bergarces
Copy link
Copy Markdown
Contributor

@bergarces bergarces commented Feb 6, 2026

Description

Corrected the following issues with the new button layout:

  • Remove token option hidden for MUSD and for tokens that are not part of the state
  • Do not show send option if the token has no balance
  • Removed some old code from a feature flag that was enabled about a year ago

Changelog

CHANGELOG entry: Fixed minor button layout issues

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI/UX logic and test updates only; no changes to transaction signing, balances, or protocol interactions beyond adjusting when buttons/options are shown.

Overview
Fixes Token Details action/menu visibility to match the new layout rules: the main actions no longer show Send when the token has no balance, and perps vs non-perps states now map to consistent button sets (covered by expanded TokenDetailsActions tests).

Updates the “More” actions menu so Remove token only appears when the token is actually present in the account’s assets and is not mUSD (new selector check + tests).

Cleans up legacy buy gating by removing the old deposit feature-flag/min-version check in TokenDetails.tsx, so displayBuyButton is now driven solely by Ramp availability.

Written by Cursor Bugbot for commit 16d77d1. This will update automatically on new commits. Configure here.

@bergarces bergarces requested a review from a team as a code owner February 6, 2026 12:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

depositActiveFlag &&
compareVersions.compare(currentVersion, depositMinimumVersionFlag, '>=')
);
})();
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been changed for almost a year, and I cannot see any more relevant references in code, so removing it from the new component.

@bergarces bergarces force-pushed the fix-button-layout-bugs branch from 61e4d7b to b8607d8 Compare February 6, 2026 13:05
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

E2E Test Selection:
Fallback: AI analysis did not complete successfully. Running all tests.

Performance Test Selection:
Fallback: AI analysis did not complete successfully. Running all performance tests.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 6, 2026

@bergarces bergarces enabled auto-merge February 6, 2026 14:03
@bergarces bergarces added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 0c99293 Feb 6, 2026
105 checks passed
@bergarces bergarces deleted the fix-button-layout-bugs branch February 6, 2026 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
@metamaskbot metamaskbot added the release-7.66.0 Issue or pull request that will be included in release 7.66.0 label Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.66.0 Issue or pull request that will be included in release 7.66.0 size-M team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants