Skip to content

fix(predict): remove Super Bowl LX temporary fix#25756

Merged
matallui merged 1 commit intomainfrom
codex/predict-remove-super-bowl-lx-fix
Feb 6, 2026
Merged

fix(predict): remove Super Bowl LX temporary fix#25756
matallui merged 1 commit intomainfrom
codex/predict-remove-super-bowl-lx-fix

Conversation

@matallui
Copy link
Copy Markdown
Contributor

@matallui matallui commented Feb 6, 2026

Description

This change removes an outdated hardcoded title override in parsePolymarketEvents for event id 188978.

Reason for change:

  1. The temporary Super Bowl-specific override is stale technical debt.
  2. It can incorrectly rewrite provider data.

Improvement:

  1. Event titles now consistently come from event.title.
  2. The TODO for the temporary workaround is removed.

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Manual testing steps

Feature: Predict event parsing cleanup

  Scenario: parser preserves provider title for legacy event id
    Given a Polymarket event payload with id "188978" and a custom title
    When `parsePolymarketEvents` parses the payload
    Then the parsed market title matches the payload title

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Single-line change to market title mapping; low complexity and no security, auth, or data persistence impact.

Overview
Removes a one-off hardcoded title override in parsePolymarketEvents that rewrote event 188978 to "Super Bowl LX".

Polymarket market titles now always come directly from event.title, eliminating stale special-casing and preventing provider data from being incorrectly rewritten.

Written by Cursor Bugbot for commit 18cc72e. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-predict Predict team label Feb 6, 2026
@matallui matallui marked this pull request as ready for review February 6, 2026 04:41
@matallui matallui requested a review from a team as a code owner February 6, 2026 04:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change is a simple cleanup that removes a temporary hardcoded workaround for a specific Super Bowl LX event (ID '188978') in the Polymarket utils. Previously, the code had a conditional: title: event.id === '188978' ? 'Super Bowl LX' : event.title, which has been simplified to just title: event.title. This is a low-risk change that:

  1. Removes dead/obsolete code (the Super Bowl LX event is likely past)
  2. Only affects how market titles are displayed in the Predictions feature
  3. Is contained within the Polymarket provider utilities
  4. Has no functional logic changes - just removes a special case

SmokePredictions is the appropriate tag as it tests Polymarket prediction market integration including market display, positions, and transactions. While SmokePredictions description mentions also selecting SmokeWalletPlatform for Trending section changes, this is a utility function change (not a view change), so the dependency is not strictly required. The change is too minor to warrant additional tags.

Performance Test Selection:
This change is a simple cleanup removing a hardcoded title workaround for a specific event. It does not affect UI rendering performance, data loading, state management, or any critical user flows. The change is purely cosmetic (title display) and has no performance implications.

View GitHub Actions results

@matallui matallui enabled auto-merge February 6, 2026 04:58
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

@caieu caieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matallui matallui added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 8864c70 Feb 6, 2026
109 checks passed
@matallui matallui deleted the codex/predict-remove-super-bowl-lx-fix branch February 6, 2026 13:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
@metamaskbot metamaskbot added the release-7.66.0 Issue or pull request that will be included in release 7.66.0 label Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.66.0 Issue or pull request that will be included in release 7.66.0 size-XS team-predict Predict team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants