Skip to content

test: update accounts E2E tests to be BIP-44 compliant#25748

Merged
gantunesr merged 4 commits intomainfrom
gar/test/update-test-bip44
Feb 6, 2026
Merged

test: update accounts E2E tests to be BIP-44 compliant#25748
gantunesr merged 4 commits intomainfrom
gar/test/update-test-bip44

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented Feb 6, 2026 •
edited by cursor bot
Loading

Description

This PR updates 3 E2E tests to be BIP-44 compliant,

  1. Delete account
  2. Add account
  3. Reveal SRP from account details

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1442

Manual testing steps

No applicable

Screenshots/Recordings

No applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test-only changes plus new fixture data; main risk is E2E brittleness from updated account ordering, indices, and hardcoded SRP strings.

Overview
Updates multichain E2E smoke tests to use new BIP-44/multichain-compliant fixtures and V2 account-details navigation, reducing reliance on feature-flag mocks and bespoke UI flows.

Adds two new FixtureBuilder presets for (1) an HD keyring + imported simple-key-pair account and (2) two HD keyrings, then rewires the delete account, add account to SRP, and export SRP from account actions tests to use these fixtures, updated account indices, and the newer SRP reveal entry point (tapAccountSrpLink).

Written by Cursor Bugbot for commit 5fe4e66. This will update automatically on new commits. Configure here.

@gantunesr gantunesr added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 6, 2026
@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Feb 6, 2026
@gantunesr gantunesr marked this pull request as ready for review February 6, 2026 00:33
@gantunesr gantunesr requested review from a team as code owners February 6, 2026 00:33
@github-actions github-actions bot added the size-M label Feb 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokeAccounts
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are all E2E test infrastructure modifications:

  1. tests/flows/accounts.flow.ts: Changed method call from tapExportSrpButton() to tapAccountSrpLink() in the goToAccountActions flow - this affects SRP export tests.

  2. tests/framework/fixtures/FixtureBuilder.ts: Added two new fixture methods:

    • withImportedHdKeyringAndTwoDefaultAccountsSimpleKeyPairAccount() - for multichain account testing with simple key pair
    • withTwoImportedHdKeyringsAndTwoDefaultAccounts() - for multi-SRP testing with two HD keyrings

  3. tests/helpers/multichain-accounts/common.ts: Added goToAccountDetailsV2() method and deprecated the old goToAccountDetails() - this is a navigation helper update for multichain accounts V2.

  4. tests/smoke/multichain-accounts/delete-account.spec.ts: Updated to use new fixtures and V2 navigation method - tests account deletion functionality.

  5. tests/smoke/multisrp/add-account.spec.ts: Simplified test using new fixtures, removed feature flag mocking - tests adding accounts to specific SRPs.

  6. tests/smoke/multisrp/export-srp-from-account-actions.spec.ts: Updated to use new fixtures, removed feature flag mocking - tests SRP export from account actions.

All modified test files use the SmokeWalletPlatform tag. The changes affect:

  • Multi-SRP wallet architecture (SmokeWalletPlatform)
  • Account management and SRP export flows (SmokeAccounts)

Running both tags ensures the test infrastructure changes work correctly and don't break existing account/SRP functionality.

Performance Test Selection:
These changes are purely E2E test infrastructure modifications (test specs, fixtures, helpers, flows). No app code is modified - only test code. There is no impact on app performance, UI rendering, data loading, or any user-facing functionality. Performance tests are not needed.

View GitHub Actions results

cursor[bot]
cursor bot reviewed Feb 6, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.57%. Comparing base (818fdae) to head (5fe4e66).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #25748      +/-   ##
==========================================
+ Coverage   80.48%   80.57%   +0.09%     
==========================================
  Files        4300     4318      +18     
  Lines      111539   112106     +567     
  Branches    23743    23913     +170     
==========================================
+ Hits        89771    90331     +560     
+ Misses      15532    15469      -63     
- Partials     6236     6306      +70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 6, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This was referenced Feb 6, 2026
Closed
Merged
gantunesr
gantunesr commented Feb 6, 2026
View reviewed changes
tests/framework/fixtures/FixtureBuilder.ts
Comment on lines +1663 to +1670
{
type: 'Snap Keyring',
accounts: [],
metadata: {
id: '01KGQQ9KV8FNENY4HRBQY094G3',
name: '',
},
},
Copy link
Copy Markdown
Member Author

@gantunesr gantunesr Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug but I think it should be kept for correctness since the vault has it

montelaidev
montelaidev reviewed Feb 6, 2026
View reviewed changes
@gantunesr gantunesr added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit d863b4b Feb 6, 2026
161 of 163 checks passed
@gantunesr gantunesr deleted the gar/test/update-test-bip44 branch February 6, 2026 12:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
@metamaskbot metamaskbot added the release-7.66.0 Issue or pull request that will be included in release 7.66.0 label Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@montelaidev montelaidev montelaidev approved these changes

@christopherferreira9 christopherferreira9 christopherferreira9 approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.66.0 Issue or pull request that will be included in release 7.66.0 size-M team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gantunesr @codecov-commenter @montelaidev @christopherferreira9 @metamaskbot