Skip to content

feat(card): cp-7.64.0 change CardHome button colors#25728

Merged
Brunonascdev merged 3 commits intomainfrom
feat/change-card-home-button-colors
Feb 5, 2026
Merged

feat(card): cp-7.64.0 change CardHome button colors#25728
Brunonascdev merged 3 commits intomainfrom
feat/change-card-home-button-colors

Conversation

@Brunonascdev
Copy link
Copy Markdown
Contributor

@Brunonascdev Brunonascdev commented Feb 5, 2026 •
edited by cursor bot
Loading

Description

Change CardHome button colors

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only styling change limited to button variants and snapshot updates, with no impact to card flows, navigation, or data handling.

Overview
Updates CardHome to render its main call-to-action buttons (Add funds, Enable card, Change asset, and the error Try again) using ButtonVariants.Primary instead of Secondary, changing their visual styling.

Regenerates CardHome Jest snapshots to reflect the new button colors (e.g., dark background and white label text).

Written by Cursor Bugbot for commit 4e6f91e. This will update automatically on new commits. Configure here.

@Brunonascdev Brunonascdev self-assigned this Feb 5, 2026
@Brunonascdev Brunonascdev added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 5, 2026
@Brunonascdev Brunonascdev marked this pull request as ready for review February 5, 2026 18:38
@Brunonascdev Brunonascdev requested a review from a team as a code owner February 5, 2026 18:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-card Card Team label Feb 5, 2026
@alescode alescode enabled auto-merge February 5, 2026 19:19
@alescode alescode disabled auto-merge February 5, 2026 19:21
@alescode alescode enabled auto-merge February 5, 2026 19:21
auto-merge was automatically disabled February 5, 2026 19:27

Pull Request is not mergeable

@Brunonascdev Brunonascdev added skip-e2e skip E2E test jobs skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) labels Feb 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeCard
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are purely visual/styling modifications to the CardHome component - changing button variants from ButtonVariants.Secondary to ButtonVariants.Primary for 5 buttons (Add Funds, Enable Card, Change Asset, and Try Again buttons). The snapshot file updates reflect the expected visual changes (background color, text color, border properties).

These changes:

  1. Do NOT affect any functionality - all button actions, test IDs, and behavior remain identical
  2. Do NOT change any test selectors - E2E tests use CardHomeSelectors which are unchanged
  3. Are purely cosmetic - changing button appearance from secondary to primary styling

While the E2E tests for Card interact with buttons via test IDs (not visual properties), selecting SmokeCard provides confidence that the Card feature still works correctly after the visual changes. The tests verify button taps, bottom sheet displays, and analytics events - all of which should continue to work with the new button styling.

No dependent tags are needed as per the SmokeCard description - SmokeTrade and SmokeConfirmations are only needed when Add Funds uses swaps, but these tests just verify the UI elements are visible and clickable, not the full swap flow.

Performance Test Selection:
No performance tests needed. The changes are purely visual/styling modifications - changing button variants from Secondary to Primary. This only affects CSS-like properties (background color, text color, border). There are no changes to: component rendering logic, data loading, state management, list rendering, or any performance-sensitive code paths.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 5, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Brunonascdev Brunonascdev added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 51f9d36 Feb 5, 2026
109 of 119 checks passed
@Brunonascdev Brunonascdev deleted the feat/change-card-home-button-colors branch February 5, 2026 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
@metamaskbot metamaskbot added the release-7.66.0 Issue or pull request that will be included in release 7.66.0 label Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alescode alescode alescode approved these changes

Assignees

@Brunonascdev Brunonascdev

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.66.0 Issue or pull request that will be included in release 7.66.0 size-XS skip-e2e skip E2E test jobs skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) team-card Card Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Brunonascdev @alescode @metamaskbot