Skip to content

fix: subtitle in token details#25726

Merged
juanmigdr merged 2 commits intomainfrom
fix/subtitle-in-token-details
Feb 6, 2026
Merged

fix: subtitle in token details#25726
juanmigdr merged 2 commits intomainfrom
fix/subtitle-in-token-details

Conversation

@juanmigdr
Copy link
Copy Markdown
Member

@juanmigdr juanmigdr commented Feb 5, 2026

Description

This bug was introduced after RWA tokens were introduced in this PR

Changelog

CHANGELOG entry: remove subtitle in token details

Related issues

Fixes: #25478 & https://consensyssoftware.atlassian.net/browse/ASSETS-2586

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

image image

After

image image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only formatting change in the asset header plus test/snapshot updates; low risk aside from potential minor layout regressions for edge-case token names.

Overview
Fixes the token details subtitle rendering in AssetOverview by combining the asset name and ticker/symbol into a single text node (name (ticker)), while preserving the special two-line layout when a stock/RWA badge is shown.

Updates Price header unit tests and the AssetOverview snapshot to match the new subtitle format, including cases where ticker is missing (falls back to symbol).

Written by Cursor Bugbot for commit a0f9bfe. This will update automatically on new commits. Configure here.

@juanmigdr juanmigdr requested a review from a team as a code owner February 5, 2026 18:21
@juanmigdr juanmigdr enabled auto-merge February 5, 2026 18:23
@github-actions github-actions bot added the size-S label Feb 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to a minor UI formatting change in the Price component (part of AssetOverview). The modification changes how asset name and ticker are displayed - combining them into a single line format "name (ticker)" when there's no stock token badge, instead of showing them on separate lines. This is purely a cosmetic/display change with:

  1. No business logic changes
  2. No navigation or user flow changes
  3. No changes to transaction, confirmation, or account management flows
  4. Unit tests and snapshots have been properly updated

The AssetOverview/Price component is used in token detail views to display price information, but this specific text formatting change doesn't impact any E2E test scenarios. None of the available E2E test tags specifically cover asset price display formatting. The change is well-contained and low-risk.

Performance Test Selection:
This change is a minor UI text formatting modification that combines asset name and ticker into a single Text component instead of two separate ones. This actually simplifies the DOM structure (fewer View and Text elements) when there's no stock badge, which if anything would be a micro-optimization. There's no impact on rendering performance, data loading, or any critical user flows that would warrant performance testing.

View GitHub Actions results

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@juanmigdr juanmigdr added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Feb 6, 2026
@juanmigdr juanmigdr added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 5b518ea Feb 6, 2026
104 of 110 checks passed
@juanmigdr juanmigdr deleted the fix/subtitle-in-token-details branch February 6, 2026 10:02
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
@metamaskbot metamaskbot added the release-7.66.0 Issue or pull request that will be included in release 7.66.0 label Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.66.0 Issue or pull request that will be included in release 7.66.0 size-S skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Token detail page - token and symbol formatting is not formatted properly

3 participants