Skip to content

fix: cash buy button action#25719

Merged
sahar-fehri merged 5 commits intomainfrom
fix-cash-buy-button-action
Feb 5, 2026
Merged

fix: cash buy button action#25719
sahar-fehri merged 5 commits intomainfrom
fix-cash-buy-button-action

Conversation

@bergarces
Copy link
Copy Markdown
Contributor

@bergarces bergarces commented Feb 5, 2026

Description

The onBuy handler drilled down to those components already handles all the logic to navigate correctly, so fallbacks and modals are removed from both the new button layout and the "More" menu.

Changelog

CHANGELOG entry: Fixed flow for "Cash buy X" button on the new token details layout

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches buy-call-to-action wiring and removes embedded ramp routing/analytics, which could change purchase entrypoints and event reporting if callers don’t supply onBuy correctly.

Overview
Fixes the token details “Cash buy” flow by making onBuy a required callback and invoking it directly from both the main TokenDetailsActions button and the MoreTokenActionsMenu, removing internal fallback navigation to fund/ramp flows.

Cleans up related ramp-specific logic and metrics/tracing in the more-actions menu, and adjusts the token-hide metric to use asset.chainId for chain_id instead of the selected network chain id.

Written by Cursor Bugbot for commit 1646360. This will update automatically on new commits. Configure here.

@bergarces bergarces requested a review from a team as a code owner February 5, 2026 16:39
@bergarces bergarces added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Feb 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

E2E Test Selection:
Fallback: AI analysis did not complete successfully. Running all tests.

Performance Test Selection:
Fallback: AI analysis did not complete successfully. Running all performance tests.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 5, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sahar-fehri sahar-fehri enabled auto-merge February 5, 2026 23:31
@sahar-fehri sahar-fehri added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit ba14ec4 Feb 5, 2026
136 of 141 checks passed
@sahar-fehri sahar-fehri deleted the fix-cash-buy-button-action branch February 5, 2026 23:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
@metamaskbot metamaskbot added the release-7.66.0 Issue or pull request that will be included in release 7.66.0 label Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.66.0 Issue or pull request that will be included in release 7.66.0 size-M skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants