Skip to content

test: MMQA-1348 component view test required#25643

Merged
racitores merged 1 commit intomainfrom
raci/component-view-test-required
Feb 6, 2026
Merged

test: MMQA-1348 component view test required#25643
racitores merged 1 commit intomainfrom
raci/component-view-test-required

Conversation

@racitores
Copy link
Copy Markdown
Contributor

@racitores racitores commented Feb 4, 2026 •
edited by cursor bot
Loading

Description

Move component view tests to the required jobs list

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
CI gating changes can block merges if component-view-test is flaky or misconfigured, but no production/runtime code paths are affected.

Overview
Makes component-view-test a required dependency for the all-jobs-pass job in .github/workflows/ci.yml, so PRs only pass the overall CI gate when component view tests run and succeed.

Written by Cursor Bugbot for commit fe35763. This will update automatically on new commits. Configure here.

@racitores racitores added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 4, 2026
@racitores racitores requested a review from a team as a code owner February 4, 2026 12:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 4, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Feb 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 4, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR makes a minimal change to the CI workflow configuration (.github/workflows/ci.yml). The only modification is adding component-view-test to the needs array of the all-jobs-pass job. This means the existing component-view-test job (which runs yarn test:view) is now a required dependency for the overall CI to pass.

Key observations:

  1. No application code is changed
  2. No E2E test code or infrastructure is modified
  3. The component-view-test job already exists and runs independently
  4. This change only affects CI job dependencies/ordering
  5. The change makes CI more strict by requiring component view tests to pass

Since this is purely a CI workflow configuration change that doesn't modify any application code, test infrastructure, or test files, no E2E tests are needed to validate this change. The CI workflow itself will validate that the change works correctly by running the jobs in the new dependency order.

Performance Test Selection:
This change only modifies CI workflow configuration by adding a job dependency. No application code, UI components, or performance-critical paths are affected. The change doesn't impact app startup, rendering, data loading, or any user-facing functionality that would require performance testing.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 4, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@racitores racitores added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit e9830b5 Feb 6, 2026
77 checks passed
@racitores racitores deleted the raci/component-view-test-required branch February 6, 2026 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
@metamaskbot metamaskbot added the release-7.66.0 Issue or pull request that will be included in release 7.66.0 label Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.66.0 Issue or pull request that will be included in release 7.66.0 size-XS team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@racitores @MarioAslau @metamaskbot