Skip to content

chore: removed usage of token-search-discovery-controller#25435

Merged
juanmigdr merged 2 commits intomainfrom
chore/remove-token-search-discovery-controller
Jan 30, 2026
Merged

chore: removed usage of token-search-discovery-controller#25435
juanmigdr merged 2 commits intomainfrom
chore/remove-token-search-discovery-controller

Conversation

@juanmigdr
Copy link
Copy Markdown
Member

@juanmigdr juanmigdr commented Jan 30, 2026

Description

The token-search-discovery-controller was used by mobile at some point to get data from the portfolio API, after investigating its use I concluded that this controller could be fully removed from the codebase. I will follow up with a PR that removes it from core

Changelog

CHANGELOG entry: removed usage of token-search-discovery-controller

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2534

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk cleanup that removes an unused controller and associated hook/tests; main risk is any remaining hidden runtime dependency on TokenSearchDiscoveryController now removed from Engine context/state and dependencies.

Overview
Removes the legacy TokenSearchDiscoveryController integration end-to-end: its Engine initialization/context wiring, messenger + init module, selectors, and the useTokenSearchDiscovery hook/tests.

Cleans up persisted/background state and logging snapshots to no longer include TokenSearchDiscoveryController, and drops the @metamask/token-search-discovery-controller dependency from package.json/yarn.lock (while keeping TokenSearchDiscoveryDataController in place).

Written by Cursor Bugbot for commit 91b82ee. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

E2E Test Selection:
Fallback: AI analysis did not complete successfully. Running all tests.

Performance Test Selection:
Fallback: AI analysis did not complete successfully. Running all performance tests.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@juanmigdr juanmigdr added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit a44c0c5 Jan 30, 2026
99 checks passed
@juanmigdr juanmigdr deleted the chore/remove-token-search-discovery-controller branch January 30, 2026 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
@metamaskbot metamaskbot added the release-7.65.0 Issue or pull request that will be included in release 7.65.0 label Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.65.0 Issue or pull request that will be included in release 7.65.0 size-M team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants