chore: removed usage of token-search-discovery-controller#25435
Merged
chore: removed usage of token-search-discovery-controller#25435
Conversation
4 tasks
Prithpal-Sooriya
approved these changes
Jan 30, 2026
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
|
tommasini
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The token-search-discovery-controller was used by mobile at some point to get data from the portfolio API, after investigating its use I concluded that this controller could be fully removed from the codebase. I will follow up with a PR that removes it from core
Changelog
CHANGELOG entry: removed usage of token-search-discovery-controller
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2534
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk cleanup that removes an unused controller and associated hook/tests; main risk is any remaining hidden runtime dependency on
TokenSearchDiscoveryControllernow removed from Engine context/state and dependencies.Overview
Removes the legacy
TokenSearchDiscoveryControllerintegration end-to-end: its Engine initialization/context wiring, messenger + init module, selectors, and theuseTokenSearchDiscoveryhook/tests.Cleans up persisted/background state and logging snapshots to no longer include
TokenSearchDiscoveryController, and drops the@metamask/token-search-discovery-controllerdependency frompackage.json/yarn.lock(while keepingTokenSearchDiscoveryDataControllerin place).Written by Cursor Bugbot for commit 91b82ee. This will update automatically on new commits. Configure here.